Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JuliaArrays/StaticArrays.jl Loading
base: 294f2ef98d9e8f5e7f435acbd179bf1045e44fb0
Choose a base ref
...
head repository: JuliaArrays/StaticArrays.jl Loading
compare: c1fd9b35c62be77e3a6fde86d36475563e08f072
Choose a head ref
  • 5 commits
  • 20 files changed
  • 1 contributor

Commits on Mar 23, 2022

  1. Define construct_type 

    Similar to `similar_type`, but not fallback to `SArray`. It is used to pick the most `concrete` constructor with `size`, `eltype` and `ndims` defined.
    @N5N3
    N5N3 committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    b552a21 View commit details
    Browse the repository at this point in the history

  2. Define general constructor with construct_type

    @N5N3
    N5N3 committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    6c095c4 View commit details
    Browse the repository at this point in the history

  3. Define general convert with construct_type. 

    And fix for input with non-1 based axes.
    @N5N3
    N5N3 committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    1f0703a View commit details
    Browse the repository at this point in the history

  4. Constructor and convertor clean. 

    With `construct_type`, there's no need to keep all these dispatches.
This also fix empty construction for `S/MVector`, and remove most of the ambiguities.
    @N5N3
    N5N3 committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    3e559c6 View commit details
    Browse the repository at this point in the history

  5. Add more test 

    test `SHermitianCompact(1,2,3,4)`
    @N5N3
    N5N3 committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    c1fd9b3 View commit details
    Browse the repository at this point in the history
Loading