You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found this pretty neat, but it would have required some major refactoring, mostly because of the parametric dispatch on glr for _solver, _fit etc. Are all these type restrictions really needed? Or could one get rid of them, maybe with a few traits?
But I am also fine with the current implementation. Please feel free to merge whenever you feel this PR is ready.
By the way, when I started working on this PR I considered for a moment an alternative implementation with a wrapper
I found this pretty neat, but it would have required some major refactoring, mostly because of the parametric dispatch on
glr
for_solver
,_fit
etc. Are all these type restrictions really needed? Or could one get rid of them, maybe with a few traits?But I am also fine with the current implementation. Please feel free to merge whenever you feel this PR is ready.
Originally posted by @jbrea in #109 (comment)
The text was updated successfully, but these errors were encountered: