Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile : various updates #326

Open
pascalandy opened this issue Nov 29, 2018 · 3 comments
Open

Dockerfile : various updates #326

pascalandy opened this issue Nov 29, 2018 · 3 comments

Comments

@pascalandy
Copy link

pascalandy commented Nov 29, 2018

Hello folks,

I see the Dockerfile needs some love.

Before contributing and pushing a PR, I would like to know your feedbacks before to do so.
Should I use a daily branch or create mine?

EDIT: To update

  • Node LTS is at v10
  • Shadowsocks is at v3.2.3
  • yarn is at v1.12.3
  • user permissions

Aggregate RUN commands

I would suggest combining many bash commands under the same RUN to minimize the number of layers in the Docker image.

Question

I don't see a CICD setup like Travis around. Is there one?

@trevj
Copy link
Contributor

trevj commented Nov 30, 2018

@pascalandy Again, thanks for trying Outline. Yes, our Dockerfile could use some love. To answer your questions, and some random comments:

As for PRs I think the easiest/best approach is just to fork off master. We don't both much with feature branches.

@pascalandy
Copy link
Author

Thanks, with all these info, I'll give it a shoot :)

@fortuna
Copy link
Collaborator

fortuna commented Jan 8, 2019

FYI, we've made several updates to the Dockerfile since this issue was posted, including updating and removing some dependencies, and changing file permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants