Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): the provided password must use unique value #1506

Merged
merged 3 commits into from
Feb 12, 2024
Merged

fix(server): the provided password must use unique value #1506

merged 3 commits into from
Feb 12, 2024

Conversation

murka
Copy link
Contributor

@murka murka commented Feb 7, 2024

Fix #1485

@murka murka requested a review from fortuna as a code owner February 7, 2024 15:07
fortuna
fortuna requested changes Feb 7, 2024
View reviewed changes
src/shadowbox/server/server_access_key.ts Outdated Show resolved Hide resolved
src/shadowbox/server/server_access_key.ts Outdated Show resolved Hide resolved
src/shadowbox/model/errors.ts Outdated Show resolved Hide resolved
@fortuna fortuna mentioned this pull request Feb 7, 2024
Closed
@murka murka requested a review from fortuna February 9, 2024 13:11
@murka murka changed the title fix(shadowbox): the provided password must use unique value fix(server): the provided password must use unique value Feb 9, 2024
fortuna
fortuna approved these changes Feb 10, 2024
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@fortuna fortuna merged commit ceca3d6 into Jigsaw-Code:master Feb 12, 2024
16 of 17 checks passed
@murka murka deleted the fix-1485 branch February 14, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return warning message when a key is generated with the same password
2 participants
@murka @fortuna