Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the code in DGL #33

Open
MrZealand opened this issue Apr 13, 2020 · 3 comments
Open

About the code in DGL #33

MrZealand opened this issue Apr 13, 2020 · 3 comments

Comments

@MrZealand
Copy link

MrZealand commented Apr 13, 2020

The code in https://github.com/dmlc/dgl/blob/master/examples/pytorch/han/model.py Line 19,Line21.
beta = torch.softmax(w, dim=1)
return (beta * z).sum(1)

The dim should be 0 ?

@mongoose54
Copy link

The features are on dim=1 . So it is correct.

@lipingcoding
Copy link

I found code in dgl obtains inferior performance. Do you have any idea? Please ref this issue! Thanks if you have time

@yzh119
Copy link

yzh119 commented Dec 11, 2020

@lipingcoding what doo you mean by performance? speed or final accuracy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants