set_theme() should accept feature_list #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48de488
to
0b69e40
Compare
alshan
requested changes
Apr 11, 2024
| theme_name = theme_options.pop('name', None) | ||
| plot_spec += FeatureSpec('theme', theme_name, **theme_options) | ||
|
|
||
| if theme_options.get('feature-list') is not None: |
There was a problem hiding this comment.
This is 3rd place where we merge 2 or more themes to 1. First two are:
- https://github.com/JetBrains/lets-plot/blob/master/python-package/lets_plot/plot/core.py#L394
- https://github.com/JetBrains/lets-plot/blob/master/python-package/lets_plot/plot/subplots.py#L74
This would result in too many duplications. We need to factor out and reuse as much code as possible.
There was a problem hiding this comment.
if 'feature-list' in theme_options:
There was a problem hiding this comment.
We don't merge theme configs, only store them. A merge is done by these two places.
We changed the way how we store a config from JSON to API objects.
Now it should be clear that this code is only used to delegate the config merge to this "mergers".
If we need to refactor this duplication from the links, I propose to do it with another PR, as it can be tricky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test-notebook: https://nbviewer.org/github/JetBrains/lets-plot/blob/set-theme/docs/dev/notebooks/set_multiple_themes.ipynb