Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the 'stroke' aesthetic. #320

Closed
alshan opened this issue Feb 15, 2021 · 0 comments · Fixed by #729
Closed

Implement the 'stroke' aesthetic. #320

alshan opened this issue Feb 15, 2021 · 0 comments · Fixed by #729
Assignees
@ASmirnov-HORIS

Comments

@alshan
Copy link
Collaborator

alshan commented Feb 15, 2021

See: http:https://ggplot2.tidyverse.org/reference/geom_point.html

For shapes that have a border (like 21), you can colour the inside and
outside separately. Use the stroke aesthetic to modify the width of the
border

ggplot(mtcars, aes(wt, mpg)) +
geom_point(shape = 21, colour = "black", fill = "white", size = 5, stroke = 5)
@alshan alshan added this to the None milestone Dec 28, 2021
@alshan alshan modified the milestones: Backlog, 2022Q4, 2023Q1 Dec 28, 2022
@ASmirnov-HORIS ASmirnov-HORIS self-assigned this Mar 23, 2023
ASmirnov-HORIS added a commit that referenced this issue Mar 24, 2023
@ASmirnov-HORIS
Mention fix #320 in the future_changes.md file.
3ef41bc
@ASmirnov-HORIS ASmirnov-HORIS mentioned this issue Mar 27, 2023
Merged
@alshan alshan modified the milestones: 2023Q1, 2023Q2 Mar 30, 2023
alshan pushed a commit that referenced this issue Mar 31, 2023
@ASmirnov-HORIS
Implementation of the 'stroke' aesthetic (#729)
ccdbc2f 
* Add stroke aesthetic and use it in points and dotplots.

* Refactor code and update stroke width calculation (make it tinier).

* Refactor: restore name of the strokeWidth function.

* Small refactor for strokeWidth in LinesHelper.

* Fix stroke width for geom_pointrange().

* Add outlier_stroke parameter to the geom_boxplot().

* Update docstrings (mention stroke parameter) and add outlier_stroke to the signature of the geom_boxplot().

* Mention fix #320 in the future_changes.md file.

* Refactor stroke aesthetic and use it in livemap.

* Remove stroke from guide.

* Stroke scaling on livemap.

* Make all the point shapes the same size. Fix triangle shapes.

* Fix point shapes on livemap.

* Fix tests (default stroke was updated).

* Last fixes in legend and tooltips (consider stroke).

* Fix triangle glyphs.

* Add 0-shape to livemap.

* Add demo notebook about stroke aes.

* Mention stroke aesthetic in 'Added' section of the future_changes.

* Update docstrings for stroke aesthetic.

* Fix problem with NaN-stroke in Renderers.

* Remove extra default value from TriangleGlyph.

* Remove extra demo with points.

* Refactor PointShape.

* Update notebook for 'stroke' aesthetic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ASmirnov-HORIS ASmirnov-HORIS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implementation of the 'stroke' aesthetic JetBrains/lets-plot
2 participants
@alshan @ASmirnov-HORIS