Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering is broken inside Databricks with DBR 11.x and higher - potential fix included #602

Closed
fwetdb opened this issue Sep 20, 2022 · 6 comments

Comments

@fwetdb
Copy link

fwetdb commented Sep 20, 2022

Hello,

lets-plot used to work on Databricks with DBR 10.x (cluster version) and lower and we have customers who love and use it.

However, with DBR 11.x the auto-renderer breaks because it detects the wrong display type.
To fix this, customers have to explicitly do LetsPlot.setup_html(isolated_frame=True) because isolated_frame is auto-detected to be False. IMO most likely as part of _detect_isolated_frame.

Databricks can be detected e.g. via "databricks" in str(os.environ) which might be added to https://github1s.com/JetBrains/lets-plot/blob/HEAD/python-package/lets_plot/frontend_context/_html_contexts.py#L68-L69 or similar.

What do you think?

@alshan
Copy link
Collaborator

alshan commented Sep 21, 2022

Sure, we can do it.
But what about DBR 10.x and lower? Will this solution still be compatible with those versions?

@fwetdb
Copy link
Author

fwetdb commented Sep 21, 2022

Great and thank you for quickly getting back @alshan !
It will be compatible because isolated_frame=True is always the right setting for Databricks - both below 10.x and above 11.x

@alshan
Copy link
Collaborator

alshan commented Sep 21, 2022

@fwetdb I've pushed your proposal to master : 429e19a

Luckily we are expecting the next release in few days so the fix is coming really soon.

@fwetdb
Copy link
Author

fwetdb commented Sep 21, 2022

That's great! The customers will really appreciate your fast fix around that!

@alshan
Copy link
Collaborator

alshan commented Sep 30, 2022

Hi @fwetdb , could you verify that the fix works? Lets-Plot v2.5.0 is out.

@fwetdb
Copy link
Author

fwetdb commented Oct 3, 2022

Hi @alshan Thank you for the reach out and the fast release. I verified that the fix worked as intended.

@alshan alshan closed this as completed Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants