-
Notifications
You must be signed in to change notification settings - Fork 49
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor isAesDiscrete. Add unit-tests.
- Loading branch information
Showing
6 changed files
with
337 additions
and
108 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
216 changes: 216 additions & 0 deletions
216
plot-stem/src/jvmTest/kotlin/org/jetbrains/letsPlot/core/spec/config/IsAesDiscreteTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,216 @@ | ||
/* | ||
* Copyright (c) 2024. JetBrains s.r.o. | ||
* Use of this source code is governed by the MIT license that can be found in the LICENSE file. | ||
*/ | ||
|
||
package org.jetbrains.letsPlot.core.spec.config | ||
|
||
import org.jetbrains.letsPlot.core.plot.base.Aes | ||
import org.jetbrains.letsPlot.core.plot.base.data.DataFrameUtil | ||
import kotlin.test.* | ||
|
||
class IsAesDiscreteTest { | ||
private val data = mapOf( | ||
"code" to listOf("a", "b", "c"), | ||
"code_num" to listOf(4.0, 5.0, 6.0), | ||
"value" to listOf(1.0, -5.0, 6.0) | ||
) | ||
|
||
private val dataInv = mapOf( | ||
"code" to listOf(2.0, 3.0, 7.0), | ||
"value" to listOf("f", "g", "h") | ||
) | ||
|
||
@Test | ||
fun `data and mapping in plot`() { | ||
val plotData = DataFrameUtil.fromMap(data) | ||
val layerData = DataFrameUtil.fromMap(emptyMap<String, String>()) | ||
val plotMapping = mapOf( | ||
"x" to "code", | ||
"y" to "value" | ||
) | ||
val layerMapping = emptyMap<String, String>() | ||
val asDiscreteMapping = emptyMap<String, String>() | ||
|
||
val isXDiscrete = DataConfigUtil.isAesDiscrete( | ||
Aes.X, | ||
plotData, | ||
layerData, | ||
plotMapping, | ||
layerMapping, | ||
asDiscreteMapping | ||
) | ||
val isYDiscrete = DataConfigUtil.isAesDiscrete( | ||
Aes.Y, | ||
plotData, | ||
layerData, | ||
plotMapping, | ||
layerMapping, | ||
asDiscreteMapping | ||
) | ||
|
||
assertTrue(isXDiscrete) | ||
assertFalse(isYDiscrete) | ||
} | ||
|
||
@Test | ||
fun `data and mapping in layer`(){ | ||
val plotData = DataFrameUtil.fromMap(emptyMap<String, String>()) | ||
val layerData = DataFrameUtil.fromMap(data) | ||
val plotMapping = emptyMap<String, String>() | ||
val layerMapping = mapOf( | ||
"x" to "code", | ||
"y" to "value" | ||
) | ||
val asDiscreteMapping = emptyMap<String, String>() | ||
|
||
val isXDiscrete = DataConfigUtil.isAesDiscrete( | ||
Aes.X, | ||
plotData, | ||
layerData, | ||
plotMapping, | ||
layerMapping, | ||
asDiscreteMapping | ||
) | ||
val isYDiscrete = DataConfigUtil.isAesDiscrete( | ||
Aes.Y, | ||
plotData, | ||
layerData, | ||
plotMapping, | ||
layerMapping, | ||
asDiscreteMapping | ||
) | ||
|
||
assertTrue(isXDiscrete) | ||
assertFalse(isYDiscrete) | ||
} | ||
|
||
@Test | ||
fun `data in plot but mapping in layer`(){ | ||
val plotData = DataFrameUtil.fromMap(data) | ||
val layerData = DataFrameUtil.fromMap(emptyMap<String, String>()) | ||
val plotMapping = emptyMap<String, String>() | ||
val layerMapping = mapOf( | ||
"x" to "code", | ||
"y" to "value" | ||
) | ||
val asDiscreteMapping = emptyMap<String, String>() | ||
|
||
val isXDiscrete = DataConfigUtil.isAesDiscrete( | ||
Aes.X, | ||
plotData, | ||
layerData, | ||
plotMapping, | ||
layerMapping, | ||
asDiscreteMapping | ||
) | ||
val isYDiscrete = DataConfigUtil.isAesDiscrete( | ||
Aes.Y, | ||
plotData, | ||
layerData, | ||
plotMapping, | ||
layerMapping, | ||
asDiscreteMapping | ||
) | ||
|
||
assertTrue(isXDiscrete) | ||
assertFalse(isYDiscrete) | ||
} | ||
|
||
|
||
@Test | ||
fun `aes use as_discrete()`() { | ||
val plotData = DataFrameUtil.fromMap(data) | ||
val layerData = DataFrameUtil.fromMap(emptyMap<String, String>()) | ||
val plotMapping = mapOf( | ||
"x" to "code", | ||
"y" to "value" | ||
) | ||
val layerMapping = emptyMap<String, String>() | ||
val asDiscreteMapping = mapOf( | ||
"x" to "code", | ||
"y" to "value" | ||
) | ||
|
||
val isXDiscrete = DataConfigUtil.isAesDiscrete( | ||
Aes.X, | ||
plotData, | ||
layerData, | ||
plotMapping, | ||
layerMapping, | ||
asDiscreteMapping | ||
) | ||
val isYDiscrete = DataConfigUtil.isAesDiscrete( | ||
Aes.Y, | ||
plotData, | ||
layerData, | ||
plotMapping, | ||
layerMapping, | ||
asDiscreteMapping | ||
) | ||
|
||
assertTrue(isXDiscrete) | ||
assertTrue(isYDiscrete) | ||
} | ||
|
||
@Test | ||
fun `data and mapping in plot with layer`() { | ||
val plotData = DataFrameUtil.fromMap(data) | ||
val layerData = DataFrameUtil.fromMap(emptyMap<String, String>()) | ||
val plotMapping = mapOf( | ||
"x" to "code", | ||
"y" to "value" | ||
) | ||
val layerMapping = mapOf( | ||
"x" to "code_num" | ||
) | ||
val asDiscreteMapping = emptyMap<String, String>() | ||
|
||
val isXDiscrete = DataConfigUtil.isAesDiscrete( | ||
Aes.X, | ||
plotData, | ||
layerData, | ||
plotMapping, | ||
layerMapping, | ||
asDiscreteMapping | ||
) | ||
assertFalse(isXDiscrete) | ||
} | ||
|
||
@Test | ||
fun `different data in plot and layer`() { | ||
val plotData = DataFrameUtil.fromMap(data) | ||
val layerData = DataFrameUtil.fromMap(dataInv) | ||
val plotMapping = mapOf( | ||
"x" to "code", | ||
"y" to "value" | ||
) | ||
val layerMapping = mapOf( | ||
"x" to "code", | ||
"y" to "value" | ||
) | ||
val asDiscreteMapping = emptyMap<String, String>() | ||
|
||
val isXDiscrete = DataConfigUtil.isAesDiscrete( | ||
Aes.X, | ||
plotData, | ||
layerData, | ||
plotMapping, | ||
layerMapping, | ||
asDiscreteMapping | ||
) | ||
val isYDiscrete = DataConfigUtil.isAesDiscrete( | ||
Aes.Y, | ||
plotData, | ||
layerData, | ||
plotMapping, | ||
layerMapping, | ||
asDiscreteMapping | ||
) | ||
|
||
assertFalse(isXDiscrete) | ||
assertTrue(isYDiscrete) | ||
} | ||
|
||
|
||
} |