From 7ef76253de60020f9ab70e7c1affaa6a7d350fbd Mon Sep 17 00:00:00 2001 From: Rashid Yangazov <129742127+RYangazov@users.noreply.github.com> Date: Mon, 6 Nov 2023 17:41:37 +0100 Subject: [PATCH] Set null as default seed value --- future_changes.md | 2 +- .../org/jetbrains/letsPlot/core/plot/base/pos/JitterDodgePos.kt | 2 +- .../org/jetbrains/letsPlot/core/plot/base/pos/JitterPos.kt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/future_changes.md b/future_changes.md index ccbe369f3a1..9a1006bf6e4 100644 --- a/future_changes.md +++ b/future_changes.md @@ -5,4 +5,4 @@ ### Changed ### Fixed - +- Jitter reproducibility in geom_jitter [[#911](https://github.com/JetBrains/lets-plot/issues/911)]. diff --git a/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterDodgePos.kt b/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterDodgePos.kt index e9ed9d14638..b067401a6c7 100644 --- a/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterDodgePos.kt +++ b/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterDodgePos.kt @@ -17,7 +17,7 @@ class JitterDodgePos(aesthetics: Aesthetics, groupCount: Int, width: Double?, ji private val myDodgePosHelper: PositionAdjustment init { - myJitterPosHelper = JitterPos(jitterWidth, jitterHeight, seed = null) + myJitterPosHelper = JitterPos(jitterWidth, jitterHeight) myDodgePosHelper = DodgePos(aesthetics, groupCount, width) } diff --git a/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterPos.kt b/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterPos.kt index 12ca233c039..35eb919dd09 100644 --- a/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterPos.kt +++ b/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterPos.kt @@ -12,7 +12,7 @@ import org.jetbrains.letsPlot.core.plot.base.GeomContext import org.jetbrains.letsPlot.core.plot.base.PositionAdjustment import kotlin.random.Random -internal class JitterPos(width: Double?, height: Double?, seed: Long?) : PositionAdjustment { +internal class JitterPos(width: Double?, height: Double?, seed: Long? = null) : PositionAdjustment { //uniform distribution private val myWidth: Double