Skip to content

Commit

Permalink
Fix deps implementation (#929)
Browse files Browse the repository at this point in the history
* Rollback to state before Kotlin update

* Fix build errors by adding implementation deps
  • Loading branch information
VDovidaytis-HORIS committed Nov 10, 2023
1 parent 11e4da5 commit 2ab2378
Show file tree
Hide file tree
Showing 5 changed files with 39 additions and 4 deletions.
5 changes: 4 additions & 1 deletion commons/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,16 @@ kotlin {

named("jsMain") {
dependencies {
implementation("io.github.microutils:kotlin-logging-js:$kotlinLoggingVersion")
compileOnly("io.github.microutils:kotlin-logging-js:$kotlinLoggingVersion")
}
}

named("jsTest") {
dependencies {
implementation(kotlin("test-js"))

// Fix for 'Could not find "io.github.microutils:kotlin-logging"...' build error (Kotlin 1.9.xx versions):
implementation("io.github.microutils:kotlin-logging-js:$kotlinLoggingVersion")
}
}
}
Expand Down
3 changes: 3 additions & 0 deletions datamodel/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ kotlin {
named("jsTest") {
dependencies {
implementation(kotlin("test-js"))

// Fix for 'Could not find "io.github.microutils:kotlin-logging"...' build error (Kotlin 1.9.xx versions):
implementation("io.github.microutils:kotlin-logging-js:$kotlinLoggingVersion")
}
}
}
Expand Down
11 changes: 10 additions & 1 deletion gis/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,18 @@ kotlin {

named("jsMain") {
dependencies {
implementation("io.ktor:ktor-client-js:$ktorVersion")
compileOnly("io.ktor:ktor-client-js:$ktorVersion")
compileOnly("io.github.microutils:kotlin-logging-js:$kotlinLoggingVersion")
}
}

// Fix for 'Could not find "io.github.microutils:kotlin-logging"...' and
// 'Could not find "io.ktor:ktor-client-js"...'build errors (Kotlin 1.9.xx versions):
named("jsTest") {
dependencies {
implementation("io.ktor:ktor-client-js:$ktorVersion")
implementation("io.github.microutils:kotlin-logging-js:$kotlinLoggingVersion")
}
}
}
}
17 changes: 15 additions & 2 deletions livemap/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,12 @@ kotlin {
sourceSets {
commonMain {
dependencies {

compileOnly(project(":commons"))
compileOnly(project(":datamodel"))
compileOnly(project(":canvas"))
compileOnly(project(":gis"))

compileOnly("io.ktor:ktor-client-websockets:$ktorVersion")
}
}

Expand Down Expand Up @@ -57,9 +58,21 @@ kotlin {
named("jsMain") {
dependencies {
compileOnly("io.ktor:ktor-client-js:$ktorVersion")
implementation("io.ktor:ktor-client-websockets:$ktorVersion")
compileOnly("io.github.microutils:kotlin-logging-js:$kotlinLoggingVersion")
}
}

/* Fix for build errors:
- 'Could not find "io.github.microutils:kotlin-logging"...'
- 'Could not find "io.ktor:ktor-client-websockets"...'
- 'Could not find "io.ktor:ktor-client-js"...'
(Kotlin 1.9.xx versions): */
named("jsTest") {
dependencies {
implementation("io.ktor:ktor-client-js:$ktorVersion")
implementation("io.ktor:ktor-client-websockets:$ktorVersion")
implementation("io.github.microutils:kotlin-logging-js:$kotlinLoggingVersion")
}
}
}
}
7 changes: 7 additions & 0 deletions plot-livemap/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,12 @@ kotlin {
compileOnly("io.github.microutils:kotlin-logging-js:$kotlinLoggingVersion")
}
}

// Fix for 'Could not find "io.ktor:ktor-client-js"...'build error (Kotlin 1.9.xx versions):
named("jsTest") {
dependencies {
implementation("io.ktor:ktor-client-js:$ktorVersion")
}
}
}
}

0 comments on commit 2ab2378

Please sign in to comment.