Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create wrapper for IDE platform icons #73

Closed
rock3r opened this issue Jun 22, 2023 · 5 comments
Closed

Create wrapper for IDE platform icons #73

rock3r opened this issue Jun 22, 2023 · 5 comments
Assignees
Labels
feature New feature or request

Comments

@rock3r
Copy link
Collaborator

rock3r commented Jun 22, 2023

Standalone is optional, but at least in the IDE theme we should have an easy way to address platform icons (AllIcons, StudioIcons, etc). This should be auto-generated from IDE sources.

@c5inco c5inco added this to the Build 1.0.0 milestone Oct 9, 2023
@c5inco c5inco added the feature New feature or request label Oct 9, 2023
@devkanro devkanro linked a pull request Oct 12, 2023 that will close this issue
@devkanro devkanro removed a link to a pull request Oct 12, 2023
@Walingar
Copy link
Collaborator

Walingar commented Feb 2, 2024

For now the way to address icons is to use Icon(key, classloader). Where the algorithm is:

  1. Find class where icon placed (like AllIcons)
  2. find icon there
  3. copy id from there
  4. Use it's class classloader

In the future IntelliJ Platform may provide just keys for Icons, so they can be used without classloader. But for now the only way is described one

@Walingar Walingar removed their assignment Feb 2, 2024
@rock3r
Copy link
Collaborator Author

rock3r commented Feb 5, 2024

Is there a tracking issue for the "just provide the IDs" feature?

@Walingar
Copy link
Collaborator

Walingar commented Feb 5, 2024

I am not aware of such issue, it was just 1n1 discussions

@rock3r
Copy link
Collaborator Author

rock3r commented Feb 5, 2024

@rock3r rock3r removed this from the Build 1.0.0 milestone Jul 9, 2024
@rock3r
Copy link
Collaborator Author

rock3r commented Jul 22, 2024

Done in #430

@rock3r rock3r closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants