Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icon loading in IJP 242 #426

Closed
rock3r opened this issue Jul 2, 2024 · 1 comment
Closed

Fix icon loading in IJP 242 #426

rock3r opened this issue Jul 2, 2024 · 1 comment
Assignees
@rock3r
Labels
bug Something isn't working release-blocker Issues that block a (stable) release of the library

Comments

@rock3r
Copy link
Collaborator

rock3r commented Jul 2, 2024

In IJP 242 the way icon mapping is done/used has changed once again. Now, AllIcons carries both the original and new UI icon paths, and the selection is done in the IconManager at the time of rasterising the SVGs.

The only solution we have is to change the icon loading code on our side once again, in some way.
@rock3r rock3r added bug Something isn't working release-blocker Issues that block a (stable) release of the library labels Jul 2, 2024
@rock3r rock3r self-assigned this Jul 2, 2024
@rock3r
Copy link
Collaborator Author

rock3r commented Jul 9, 2024

Done in #430

@rock3r rock3r closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rock3r rock3r

Labels
bug Something isn't working release-blocker Issues that block a (stable) release of the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rock3r