Refactoring New UI implementation based on core components

[devkanro]

Look and feel

• Palettes Basic colors have been added, it will be changed in future
• Painters SVGs have been redesigned for Checkbox and Radio button, it does not copy from IJ because there are many temp icons in 22.3
• Metrics Just copy from Darcula theme, need check and adjust
• Typography Change the default font to Inter

Core component support

• Focus style support
  • Border alignment support #34

Consistency check

• Check box
• Radio button
  • Fix focus state not saved after selected state changed #31
  • Optimize modifiers of Checkbox and RadioButton #32
• Buttons Need focus style support
  • Fix button focus style #33
• Slider Current implemented by swing component
• TextField Missing round border style, focus style, heading icon and trailer icon
  • TextField control #43
  • New UI refactoring #27
• ProgressBar Missing implementation
  • New UI refactoring #27
• SegmentedButtonColors Missing implementation
• TextArea Missing implementation
  • Add TextArea #39
• Link and DropdownLink Missing implementation
• ToolTip Missing implementation
• DropdownMenu Missing implementation
• ContextMenu Missing implementation
• ComboBox Missing implementation
• And more...

Consistency Issue

• Rounded rectangles not consistent with IJ #35

Project struct

• Remove old impl
• Grallery app

[RivanParmar]

@devkanro Are contributions allowed for this issue? If yes, then I would like to work on it.

[devkanro]

@RivanParmar Of course, I'm now blocked by some other works, feel free to submit PRs, but don't forget to check the manual

[RivanParmar]

@devkanro Are there any guidelines on how to structure the code? Since Checkbox, RadioButton and others are structured differently than each other. Also where should I look for implementation reference?

And it would be great if discussions could be enabled for the project so that implementation ideas could be discussed over there.

[rock3r]

The guiding principle is to try and do as close to Material as possible, because that API has been iterated and battle tested a lot, and also folks are familiar with it.

And yes, this means we'll have to go back and tweak existing code in this repo...

[RivanParmar]

@rock3r What is the difference between a TextField and a TextArea? If it's same except for the number of lines, then would it be okay to implement TextField and TextArea in the same file with a common base?

[rock3r]

@RivanParmar they are very similar in functionality and the main difference is that an area is multiline and a field is not. I think it's ok for now to put them in the same file. The only thing I'd recommend is to check the swing implementation of the two and compare if they also look the same. You can use the UI inspector for that (details in the readme). The alternative is looking at the various Darcula*UI code and seeing how they work. There may be slight cosmetic differences between the two.

[devkanro]

@RivanParmar TextArea has an footer message about history, but I can't be sure if this feature is still preserved in the new ui...

https://jetbrains.design/intellij/controls/text_area/#history

[c5inco]

I have actually not seen that history feature used consistently in TextAreas in the IDE. I would not worry about having it implemented yet, as it can easily be composed together with the field itself later, and I think we should reconsider whether it should be coupled this way.

[devkanro]

@c5inco But these footer messages still can be found in the settings of version 23.1

[c5inco]

Sure but I'm not sure it needs to be baked in just yet. We can approach the architecture of these components differently now that we're using Compose

[devkanro]

@c5inco you are right, the history has been moved to outside of text area, users can simply compose lable and text area to impl it.

[rock3r]

This is essentially done as of 0.5.0