You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
My name is Casey Baggz and I'm good friends with Schobert (we used to work together). I was actually going to build this component but saw you've already started the process. After trying to use it, I actually needed more functionality out of it so I decided to do an upgrade to make this tool similar to others in the React community by creating a HOC.
I'm halfway through but wanted to give you a heads up that I'll be submitting a PR soon with updated docs, etc. At a high level, it's moving to the same pattern that react-redux, react-refetch, etc. are using by providing a HOC function where you pass in your presentational component in the return. This will allow users to access the pure data and not have to force a non-JSX route regarding templates.
Oh wow! Very cool! Thanks for the hard work and detail @caseybaggz!
I was in the process of moving to prettier (well, standard-prettier) in the beta. However, I can tack that on afterward if it's still needed. This all sounds wonderful. Please let me know anyway I can help.
I can definitely bring down your branch and test it out, for example.
Thanks again!
Edit: I see you are way ahead of me. This is looking great! 😀️
Hey @JeromeFitz,
My name is Casey Baggz and I'm good friends with Schobert (we used to work together). I was actually going to build this component but saw you've already started the process. After trying to use it, I actually needed more functionality out of it so I decided to do an upgrade to make this tool similar to others in the React community by creating a HOC.
I'm halfway through but wanted to give you a heads up that I'll be submitting a PR soon with updated docs, etc. At a high level, it's moving to the same pattern that
react-redux
,react-refetch
, etc. are using by providing a HOC function where you pass in your presentational component in the return. This will allow users to access the pure data and not have to force a non-JSX route regarding templates.You can check out the initial README here: https://github.com/caseybaggz/react-instafeed
I've also upgraded the suite to include more tools that are common in today's React open-source projects: storybook and Jest with Enzyme.
I think I might be done by the EOW and we can reconvene then.
The text was updated successfully, but these errors were encountered: