Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to change default browser #1

Closed
ghost opened this issue Aug 6, 2017 · 8 comments
Closed

An option to change default browser #1

ghost opened this issue Aug 6, 2017 · 8 comments

Comments

@ghost
Copy link

ghost commented Aug 6, 2017

Hi, it's a great extension. I wonder if this can provide an option for changing default browser to open the html? I know that Browsersync has an browser option.

@Jasonlhy
Copy link
Owner

Jasonlhy commented Aug 9, 2017

Currently no, but I believe it can be changed according to the documentation here. But where would you like to put this setting? The modal input dialog or project configuration file?

@ghost
Copy link
Author

ghost commented Aug 9, 2017

I think project configuration file or vscode default settings would be good.

@Jasonlhy
Copy link
Owner

Jasonlhy commented Aug 9, 2017

@Nil-Zil Added a configuration paremter You can set it under workspace setting or user setting. Give it a try 👍

@ghost
Copy link
Author

ghost commented Aug 10, 2017

Thank you for your timely response! I found that no browser was opened after I started the server. I think I used it correctly because I can open it at side panel, but it does not open in browser automatically now.

@Jasonlhy
Copy link
Owner

Jasonlhy commented Aug 10, 2017

@Nil-Zil Omg I forgot if ([]) evaulate to true. I should always review this article. I will fix it as soon as possible

@Jasonlhy
Copy link
Owner

@Nil-Zil This problem should be fixed in new version 1.1.1. I just published it.

@ghost
Copy link
Author

ghost commented Aug 10, 2017

Thank you very much! It works! For default "chrome" option I still cannot open my chrome, but I reviewed this and changed it to "google chrome" or "Google Chrome" on macOS 10.12.6. Then it works!

@Jasonlhy
Copy link
Owner

I need to use "google chrome" on window :octocat: , I will update the readme and package json later. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant