Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only the first email is validated #3

Open
McCrisp opened this issue Jun 20, 2017 · 1 comment
Open

Only the first email is validated #3

McCrisp opened this issue Jun 20, 2017 · 1 comment
Labels

Comments

@McCrisp
Copy link

McCrisp commented Jun 20, 2017

As the code is now, if the first email in the list does not validate against the users domain, you get an error for wrong email domain.

So no matter how many emails you have in the list, if the first does not validate, the user is told that their email is not valid for registration.

There is a simple solution tho, if you move the code that throws the error outside the loop, everything should work fine.

@JasonEtco
Copy link
Owner

Thanks for bringing it to my attention ❤️ I'm a little busy nowadays, but feel free to open up a PR to fix this. Many thanks!

@JasonEtco JasonEtco added the bug label Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants