Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Little Bug #13

Open
IWantBecomeStronger opened this issue Jan 4, 2024 · 2 comments
Open

Little Bug #13

IWantBecomeStronger opened this issue Jan 4, 2024 · 2 comments

Comments

@IWantBecomeStronger
Copy link

IWantBecomeStronger commented Jan 4, 2024 •
edited

Hello,Thorbecke, I find a little bug in Code "fdacrtmc" ,in file "boundaries.c" ,The PML in acoustic scheme has a bug.The location is line 293,code is "for(iz=mod->iePz,ipml=0 ; izieZzb ; iz++) " ,Max lose "ipml++",and it causes a false reflection in the lower right corner of the simulated area.
image

            A Marchenko learner from China,thanks!!!
@JanThorbecke
Copy link
Owner

Thank you very much for reporting this bug ! This helps us to make the code more stable.

The bug is now fixed in the repository and available.

with kind regards,

Jan

@IWantBecomeStronger
Copy link
Author

My pleasure!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JanThorbecke @IWantBecomeStronger