Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fields are dropped when exporting to Hayagriva #10596

Closed
2 tasks done
Enivex opened this issue Oct 28, 2023 · 3 comments · Fixed by #10633
Closed
2 tasks done

Some fields are dropped when exporting to Hayagriva #10596

Enivex opened this issue Oct 28, 2023 · 3 comments · Fixed by #10633
Assignees
Labels
export / save good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@Enivex
Copy link

Enivex commented Oct 28, 2023

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

23H2

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Create a .bib file containing the following
@Article{Euler1757,
  author  = {Euler, Leonhard},
  journal = {Mémoires de l'académie des sciences de Berlin},
  title   = {Principes généraux du mouvement des fluides},
  year    = {1757},
  pages   = {274--315},
}
  1. Export to Hayagriva yaml
  2. The result is
---
Euler1757:
  type: article
  title: "Principes généraux du mouvement des fluides"
  author:
    - Euler, Leonhard
  date: 1757
  page-range: 274--315
---

As is evident, the journal is not there. In comparison, the output from the hayagriva CLI is

---
Euler1757:
  type: article
  author: "Euler, Leonhard"
  parent:
    - type: periodical
      title:
        value: "Mémoires de l'académie des sciences de Berlin"
        sentence-case: "Mémoires de l'académie des sciences de berlin"
  date: 1757
  title: Principes généraux du mouvement des fluides
  page-range: 274-315

JabRef 5.12--2023-10-26--d6a0e59
Windows 11 10.0 amd64
Java 21.0.1
JavaFX 20.0.2+3

Appendix

...

Log File
Paste an excerpt of your log file here
@Siedlerchr
Copy link
Member

Seems like the field journal is missing here https://github.com/JabRef/jabref/blob/b6d8f826b71b6489b636b01e3da8c26833ccb117/src/main/resources/resource/layout/hayagrivayaml.layout

Needs to be added and probably the tests need to be adjusted as well

@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. export / save labels Oct 28, 2023
@koppor
Copy link
Member

koppor commented Oct 28, 2023

@JawadTUE Are you still looking for an issue? Maybe, this is a good follow-up.

@JawadTUE
Copy link
Contributor

Yes, I implemented the Hayagriva yaml in #10451, but I left the parent field out. Seems like I should have added that anyway. So please assign me to this issue so I can try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
export / save good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants