Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to disable user-specific comments #10424

Closed
2 tasks done
tobiasdiez opened this issue Sep 27, 2023 · 9 comments · Fixed by #10610
Closed
2 tasks done

Not possible to disable user-specific comments #10424

tobiasdiez opened this issue Sep 27, 2023 · 9 comments · Fixed by #10610
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor
Milestone

Comments

@tobiasdiez
Copy link
Member

JabRef version

5.10 (latest release)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

Go to the comments tab. There you now find fields of the form comment-{name}. This is might be nice if you work on the bib file with more than one person, but I would assume most people don't really need this. However, it doesn't seem to be possible to toggle it this feature off (and in my opinion it should be off by default).

Refs #9727 and koppor#543. @koppor

Appendix

...

Log File
Paste an excerpt of your log file here
@koppor
Copy link
Member

koppor commented Sep 27, 2023

You are the only one concerned by this. We can keep the issue open and see if more have this suggestion.

Depends on #8701.

Right click an disable. Then stored in library settings for future.

@tobiasdiez
Copy link
Member Author

I don't think this should be stored in the bib file. I would add a toggle in the prefs (or actually respect what is written in the fields textbox).

I think the comments tab is not used by many people in the first place. But right now I'm loosing half of my editor for nothing...

@Siedlerchr
Copy link
Member

Have you tried modifying it with Custom editor tabs in the prefs?
grafik

@tobiasdiez
Copy link
Member Author

I don't know what I should specify there to hide the user comment. And looking at the code it's always shown.

@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs entry-editor labels Sep 28, 2023
@tobiasdiez tobiasdiez added this to the 5.11 milestone Sep 28, 2023
@koppor
Copy link
Member

koppor commented Sep 28, 2023

I don't think this should be stored in the bib file.

My reasoning:

  1. There are (at least) to types of .bib files: One shared within a research group and one used for one's own research (more on different types at Support of different type of BibTeX files #160). Since I am very often working in research groups, I really rely on this commenting feature.
  2. JabRef cannot know if the file at hand is a research-group file
  3. I assume that users of JabRef work in research groups

Maybe assumption 3 is wrong.

Until we have a nice welcome screen advertisting features (refs https://github.com/JabRef/jabref-issue-melting-pot/issues/49), I would keep that feature.

Other options, I see:

  • Not show it until there is one comment field in the whole library. Con: determing that needs time. Con: There needs to be at least one field

I would add a toggle in the prefs (or actually respect what is written in the fields textbox).

The textbox needs to be reworked IMHO. It seems like a low-level configuration thing only "accessible" for JabRef pro users. JabRef's tabs are not fully configurable by that preference, only some.

IMHO, that configuration makes sense if JabRef is used for something different than literature management. For instance, DVD collections, person list, ... - In the field of literature management, JabRef should offer "best practices" and not force the users to configure something.

@tobiasdiez
Copy link
Member Author

If you need the user specific comments you can enable them in your jabref, if not then let it be disabled. Sounds like a good enough solution to me, a finer per-bib solution is not necessary. Just keep it simple I would say.

@koppor koppor modified the milestones: 5.11, 5.12 Oct 12, 2023
@PenguinJunk
Copy link

My apologies that I am very low on capacity and so cannot dig deep into the nuances of this issue. I am a HEAVY user of comments. I also appreciate the possibility of sharing .bib (I maintain it as git repo) for others to add their comments. However, right now, this function is creating an overhead for me. In case it is of interest, I will put here how this affects me.
The 'default' location for comments in Jabref is now the comment-{username} box. At very least, I'd appreciate it if I could move this to a lower position, or simply turn it off, OR rename the field.
My main concern here is that I use only my phone (Android) and e-paper for my days at Uni. This means it is very difficult to access my .bib whilst there - with all my comments on my readings. To overcome this (and to create a check that my bib entries are formatted correctly), within my bib repo I have a tex file that writes a biblatex bibliography that I have customised to include my comments. However, I cannot figure out how to include comments entered into a field with a different name (the biblatex documentation is impenetrable imo).
I'm sure that when I have finished my study I will have enough capacity to understand this more, but then it will be too late!

@koppor
Copy link
Member

koppor commented Oct 31, 2023

I changed the logic not to show the user-specific comment field and to contain an "Add" button below the normal field. Feel free to try out the build at https://builds.jabref.org/pull/10610/merge/.

For me, promoting the feature is important - even though it is useful for group-work only. Let's see whether this is acceptable for you @PenguinJunk

Screenshots are available at #10610

@PenguinJunk
Copy link

That works very nicely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants