Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RateLimiter based on Weight #174

Open
nikkozp opened this issue Jan 3, 2019 · 5 comments
Open

Add RateLimiter based on Weight #174

nikkozp opened this issue Jan 3, 2019 · 5 comments

Comments

@nikkozp
Copy link
Contributor

nikkozp commented Jan 3, 2019

Hey. Noticed that you have a RateLimit which is responsible for requests per second.

Binance uses Weight in its queries. Do you have plans to add RateLimitBehaviour with Weight?

@JKorf
Copy link
Owner

JKorf commented Jan 9, 2019

Hi, I might add this add some point, but I'm currently busy with some other stuff. I'll keep this issue open so I won't forget it.

@JKorf JKorf changed the title Offer RateLimitWeight Add RateLimiter based on Weight Jan 9, 2019
@nikkozp
Copy link
Contributor Author

nikkozp commented Jan 9, 2019

Thanks.
Want to leave their wishes:

  1. Ability to set HighPriority for the request to work without delay, but not exceed the Weight. Globally and for each request separately.

@pyerpl
Copy link

pyerpl commented May 14, 2019

Also thanks
it will be very useful for me also (weighted + priority)

@MarkusGalant
Copy link
Contributor

Thanks.
Want to leave their wishes:

  1. Ability to set HighPriority for the request to work without delay, but not exceed the Weight. Globally and for each request separately.

Maybe we have delayed because every Api call check server time by Api call.

@JKorf
Copy link
Owner

JKorf commented Mar 9, 2022

The latest versions have a refactored rate limiting system, and a default rate limiter applied for the client. With this the weight of requests to the Binance API have been added. As for a priority request, this is not something I could easily add in. I would suggest working around this by creating a new client without rate limiter and using that for priority requests while maybe lowering the rate limit on the normal client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants