Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config] get/set should handle nested keys on nonexistent keys #20

Open
JBallin opened this issue Feb 2, 2021 · 0 comments
Open

[config] get/set should handle nested keys on nonexistent keys #20

JBallin opened this issue Feb 2, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JBallin
Copy link
Owner

JBallin commented Feb 2, 2021 •
edited
Loading

Reproduce

$ ballin_config get test.nested
$ ballin_config set test.nested test

Expected

INVALID: "test" doesn't exist in config

Actual
Throws JS errors

Note

  • Both get and set should prepend the error message with INVALID, but currently get does not - so it's ok if the error does not contain it for get.
  • Error is handled properly for top-level keys already (ballin_config get test returns "test" doesn't exist in config).
@JBallin JBallin added good first issue Good for newcomers bug Something isn't working labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JBallin