Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to run with League of legends #35

Closed
DereC4 opened this issue Apr 27, 2024 · 6 comments · Fixed by #36
Closed

Doesn't seem to run with League of legends #35

DereC4 opened this issue Apr 27, 2024 · 6 comments · Fixed by #36
Assignees
Labels
enhancement New feature or request

Comments

@DereC4
Copy link

DereC4 commented Apr 27, 2024

It appears you have to open the game separately entirely, which is a bit of a shame.

Is this intended behavior for this app? Or is it supposed to open the League of Legends game along with it?

It's such a great feature, what your custom RPC does, that if this isn't already in I'd like it to be considered.

@Its-Haze
Copy link
Owner

Hi, thanks for the feedback!

Currently, it does not start the game client itself. I understand that it's a feature that would be nice to have.

I mostly didn't want to add this in because it requires the user to specify the full path of the league client, if it's not found in it's default location.
I want this app to be able to start independent of the status of league, meaning that you should be able to start this app even if you are in the middle of a game.

So a few things would be needed here

A new optional argument --launch-league. If no path is given, it will check the default/most common place where league should be installed. And only if the client is not running, it will launch, otherwise it will proceed as it does now.

If a path is given, like --launch-league=<path-to-client>, then it will of course use that file path instead.

I will look and see what i can cook up.

Please let me know if you have suggestions or other things that might be relevant to this issue. Thanks

//Haze

@DereC4
Copy link
Author

DereC4 commented Apr 28, 2024

yea i figure most people would want to have the app basically run with the league rpc, so that's my idea

@Its-Haze Its-Haze self-assigned this Apr 29, 2024
@Its-Haze Its-Haze added the enhancement New feature or request label Apr 29, 2024
@Its-Haze Its-Haze linked a pull request Apr 29, 2024 that will close this issue
@Its-Haze Its-Haze pinned this issue Apr 29, 2024
@Its-Haze
Copy link
Owner

Its-Haze commented Apr 29, 2024

Hi @DereC4 , I hope this new release v2.1.0 finds you well. I have added the feature for league to automatically launch when you start this application.

By default, it will look at the default installation path for league of legends. But if you happen to have installed league in a different drive, Then please specify the full path to the client executable.
Instructions on this are in the Readme.

Let me know how it works for you! :)

@DereC4
Copy link
Author

DereC4 commented Apr 30, 2024

kk i'll take a look

@Its-Haze
Copy link
Owner

Hi @DereC4 , Hope all is well.

Do you have any feedback on the implementation?
Does it work for you?, Is it working any good?

Thanks
// Haze

@DereC4
Copy link
Author

DereC4 commented May 13, 2024

works pretty well thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants