Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML config isn't being read properly #3

Closed
jessezhang91 opened this issue Aug 22, 2023 · 1 comment
Closed

YAML config isn't being read properly #3

jessezhang91 opened this issue Aug 22, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jessezhang91
Copy link

Hello, first off thanks for this plugin!

I noticed when trying to configure a YML projectStructurerc file that it isn't being loaded. Looking at the code, I think the problem is here:
https://github.com/Igorkowalski94/eslint-plugin-project-structure/blob/main/src/validators/validateFileStructure/helpers/readConfigFile.ts#L12-L22

The YAML loader is falling through to the JSON loader on success rather than returning.

It should instead probably be something like:

    let config = null;

    try {
        return load(readFileSync(configPath, "utf8"));
    } catch (error) {
    }

    return JSON.parse(readFileSync(configPath, "utf-8"));
@Igorkowalski94
Copy link
Owner

Igorkowalski94 commented Aug 22, 2023

Fixed in version 1.4.0. Thank you for using my plugin and reporting a bug ;*

Remember to add extension at the end:
"project-structure/config-path": "yourConfigName.yaml",

@Igorkowalski94 Igorkowalski94 self-assigned this Aug 25, 2023
@Igorkowalski94 Igorkowalski94 added the bug Something isn't working label Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants