Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with object activation/updates on diff dumps in DB IDO #6012

Closed
6 tasks
dnsmichi opened this issue Jan 18, 2018 · 10 comments
Closed
6 tasks

Problems with object activation/updates on diff dumps in DB IDO #6012

dnsmichi opened this issue Jan 18, 2018 · 10 comments
Labels
area/db-ido Database output bug Something isn't working stalled Blocked or not relevant yet

Comments

@dnsmichi
Copy link
Contributor

dnsmichi commented Jan 18, 2018

There are various reported problems for this. This issue collects them all, as they all relate to each other. It also increases visibility on GitHub.

A possible fix should include all of them. PRs welcome.

Workaround

mysql icinga

update icinga_hosts set config_hash=null;
update icinga_service set config_hash=null;
update icinga_timeperiod set config_hash=null;

exit

systemctl reload icinga2

Notes

  • groups and timeperiod_timeranges are referenced tables
  • check_period might not be included in the hash check
  • object deletion and creation might not trigger events at runtime (OnVersionChanged)
@Crunsher
Copy link
Contributor

Crunsher commented Sep 4, 2018

#6569 could be added to the list

@dnsmichi
Copy link
Contributor Author

This is a candidate for a wont-fix, leaving this open up until IcingaDB is released.

@dnsmichi dnsmichi added stalled Blocked or not relevant yet wontfix Deprecated, not supported or not worth any effort labels Nov 15, 2019
@dnsmichi
Copy link
Contributor Author

@Al2Klimov Why did you close this without further comment?

@dnsmichi dnsmichi reopened this Feb 24, 2020
@Al2Klimov
Copy link
Member

Because it's a won't-fix.

@Thomas-Gelf
Copy link
Contributor

Thanks @dnsmichi. Incomplete IDO config refreshes are a massive problem for some of our customers, IMHO this should be fixed with urgency.

@dnsmichi dnsmichi removed the wontfix Deprecated, not supported or not worth any effort label Feb 24, 2020
@dnsmichi
Copy link
Contributor Author

Ok, seems this was not clear from the description, I have removed the label.

From discussions in the past - even when IcingaDB is released, it will take months or years until everyone has migrated from the IDO backend to the new backend.

Also, not fixing IDO related issues will only work when it officially is deprecated. Which imho is not possible at the very moment, correct me if I am wrong @lippserd.

@Thomas-Gelf I cannot influence the time resources here, but at least the config_hash problems in various environments should be tackled in the coming months. There sometimes is a problem with the algorithm detecting whether to fire a full heavy config update vs a light one. I don't know why exactly, but the hash calculations for object attributes need a review.

In order to avoid multiple issues tackling the same problem, this issue shall remain open as a reminder and global task list.

@Thomas-Gelf
Copy link
Contributor

I have no problem with major similar issues being combined into a single dedicated issue. At least when such issues are then somehow prioritized. It becomes problematic once we re-label such combined issues into an evaluation/reminder/maybe-issue. Those then tend to be silently stalled/wontfixed/closed.

@lippserd: I'm aware of at least one large setup that faced this issue multiple times. They're running scary workarounds in production and strongly believe that this is gonna be fixed. It would be fantastic if we could schedule this. Just to make sure that it will not be forgotten ;-)

Thanks,
Thomas

@julianbrost
Copy link
Contributor

Some of the issues mentioned in here sound like they might have been already fixed by PRs like #8626 and I'm pretty sure there also was a fix for custom vars not being written to IDO properly.

I haven't checked all of them in detail, is anyone subscribed to this issue is aware of some of those still being a problem?

@K0nne
Copy link
Contributor

K0nne commented Sep 22, 2021

The mentioned PR has fixed those problems on our side. I am happy so far 👍🏻

@julianbrost
Copy link
Contributor

This is a candidate for a wont-fix, leaving this open up until IcingaDB is released.

Which has now finally happened, so let's do this.

@julianbrost julianbrost closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/db-ido Database output bug Something isn't working stalled Blocked or not relevant yet
Projects
None yet
Development

No branches or pull requests

6 participants