Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer to peer code review Week-3 12-05-2023 #8

Closed
hafedEfheij opened this issue May 12, 2023 · 0 comments
Closed

Peer to peer code review Week-3 12-05-2023 #8

hafedEfheij opened this issue May 12, 2023 · 0 comments

Comments

@hafedEfheij
Copy link

Great job with your code! we have some suggestions that might be helpful.

Team Suggested Changes ♻️:

@hafedefhej
I noticed that you split your CSS code into multiple files. Perhaps it would be better to consolidate them into one or two files for improved organization and easier maintenance. it is considered good practice to modularize CSS code into smaller, more manageable files, however consolidating CSS code into a single file can reduce the number of HTTP requests required to load the website, which can improve website performance. This is because the browser has to make a separate request for each file that is linked to the HTML document,

The use of gap in .contact-form may not be supported in older browsers.

The font-family property is set to "Inter", sans-serif, which assumes that the Inter font is available on the device. If the font is not available, the browser will fall back to the default sans-serif font, which may not match the design intent.

The use of align-self: center in .contact-section--wrapper may not work as intended if the parent container does not have a defined height.

and One of the aspects I particularly appreciate about your project is the level of detail evident in your commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant