-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calc 3D distance between positions #8
Labels
bug
Something isn't working
Comments
This should have been addressed in commit de23e44 but we saw some issues in the field during testing. Tracking seemed to improve when 2D coordinate distance calculations were used instead. The calculation for this happens here: https://github.com/IQTLabs/SkyScan/blob/main/tracker/utils.py#L51 |
@mchadwick-iqt tested the functionality and confirmed that the calculations were correct. Closing |
Test1:
Test2:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the distance of different planes from the camera is calculated based solely on their 2d positions. The Altitude of the planes should also be taken into consideration.
An additional function should be added, based on coordinate_distance() that also takes in altitude and calculates the relative distance in 3 dimensional space between them.
The calls will need to be updated to use this new function:
https://github.com/IQTLabs/SkyScan/blob/main/tracker/flighttracker.py#L156
https://github.com/IQTLabs/SkyScan/blob/main/tracker/flighttracker.py#L352
https://github.com/IQTLabs/SkyScan/blob/main/tracker/flighttracker.py#L374
https://github.com/IQTLabs/SkyScan/blob/main/tracker/flighttracker.py#L413
https://github.com/IQTLabs/SkyScan/blob/main/tracker/flighttracker.py#L430
The text was updated successfully, but these errors were encountered: