Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing 1, 2, 3? #6

Closed
jspeed-meyers opened this issue Feb 23, 2021 · 3 comments
Closed

Testing 1, 2, 3? #6

jspeed-meyers opened this issue Feb 23, 2021 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@jspeed-meyers
Copy link
Contributor

@luke-iqt, I am going to have to call the test police. I don't see a single test. For the machine learning journal club this Wednesday, I am doing a presentation on pytest, the popular python testing framework. I am thinking of adding tests to one of the Labs projects that doesn't already have tests. I was considering this project. If there was one file in here that you would appreciate tests for, which one is it? You can also say, "Test police! Get out of here!"

@jspeed-meyers jspeed-meyers added the question Further information is requested label Feb 23, 2021
@luke-iqt
Copy link
Contributor

The Emoji Police Called! 🚨 There were soooo many missed opportunities in this above Issue.

I think we have a good data flow to dip our toes in the water. We are doing some meter/feet conversions... probably good to make sure that is 💯.

We could start with this file: https://github.com/IQTLabs/SkyScan/blob/main/tracker/utils.py

Eventually we would want to send MQTT messages and observe the action in different containers...

@jspeed-meyers
Copy link
Contributor Author

😿, don't send the emoji police! I can do better: 🚓, no need to investigate me. Okay, thank you for pointing out this file. I'll make a try at testing those functions via pytest within the next 24 hours. Expect a PR with some unittests.

@jspeed-meyers
Copy link
Contributor Author

Done! PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants