Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dev/test instances of the CANdy-Dev BC Issuer #7

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Remove the dev/test instances of the CANdy-Dev BC Issuer #7

merged 1 commit into from
Jan 21, 2022

Conversation

swcurran
Copy link
Collaborator

Signed-off-by: Stephen Curran [email protected]

@WadeBarnes
Copy link
Contributor

I listed all three environments, because the verifiers in each environment will only accept a credential from the issuer in their corresponding environment.

@swcurran
Copy link
Collaborator Author

Not completely certain what that means, but... The fact that we have the concept of Dev/Test/Prod for the issuers, and for CANdy (Dev now, but Test, Prod later) makes this a bit confusing, so this is an attempt to minimize that confusion.

The Dev and Test issuers are really just the concern of the BC Developers/SRE folks, not for external folks. This website is targeting the external folks, and as such, I think it is easier to just mention the "Prod" Issuer linked to the CANdy-Dev environment. The BC tracking of all of our deployments (in the "Inventory" Trello board) still lists all three Issuer instances.

Make sense?

Copy link
Collaborator

@flihp27 flihp27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you deleted the dev line, shouldn't you also change the label ('prod') for ('dev') on the line that you are keeping ?

@swcurran
Copy link
Collaborator Author

No -- this is the "Prod Issuer" for the "CANdy-Dev" instance. Nice and confusing... :-)

@swcurran swcurran merged commit b82b63b into ICCS-ISAC:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants