Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Contribution Completion Checklist #27

Closed
2 tasks done
chanskw opened this issue Dec 7, 2016 · 5 comments
Closed
2 tasks done

Initial Contribution Completion Checklist #27

chanskw opened this issue Dec 7, 2016 · 5 comments

Comments

@chanskw
Copy link
Collaborator

chanskw commented Dec 7, 2016

  • Testing of services - James
  • Documentation - Samantha

@cancilla
Please mark complete and give thumbs up if we are ready to go.

@cancilla
Copy link
Collaborator

cancilla commented Dec 7, 2016

I've tested and verified that the following services build and run successfully:

  • com.ibm.streamsx.health.ingest.physionet.service.PhysionetIngestService
  • com.ibm.streamsx.health.hapi.services.OruR01Ingest
  • com.ibm.streamsx.health.analysis.ecg.service.RPeakDetectService
  • com.ibm.streamsx.health.beacon.ECGBeaconService

@chanskw
Copy link
Collaborator Author

chanskw commented Dec 7, 2016

@cancilla I tried running gradle build for physionet ingest service and RPeakDetect , but I don't seem to get an output directory with the service build content... can you please take a look?

Can you let me know where I should invoke the build from and where I should expect to see output. I do see the output directory for the ECGBeaconService

@chanskw
Copy link
Collaborator Author

chanskw commented Dec 8, 2016

@cancilla I fixed the build scripts to include buildServivces target for both cases, can you please take a look and try this out.

@chanskw
Copy link
Collaborator Author

chanskw commented Dec 8, 2016

@cancilla and @petenicholls I have completed the documentation for the repository, please take a quick look at the write up and give +1 it looks good. When that is done, we can declare victory.

@chanskw
Copy link
Collaborator Author

chanskw commented Dec 14, 2016

Closing. All done!

@chanskw chanskw closed this as completed Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants