Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for chat format #989

Open
yoavkatz opened this issue Jul 3, 2024 · 0 comments
Open

Better support for chat format #989

yoavkatz opened this issue Jul 3, 2024 · 0 comments

Comments

@yoavkatz
Copy link
Member

yoavkatz commented Jul 3, 2024

  1. Seperate the structured representation and make it available at a dedicated field for people want to use it externally (e.g for using open ai api) (2) change existing formats to use this mechanism

There are downsides for using HF Tokenizer chat template - it requires access to the HF model page (e.g. sometime requires huggingface token login ).
I think we should consider a general jinja format - so people can just copy the jinja string and use it for formatting.

Originally posted by @yoavkatz in #988 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant