Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication to support different ES versions #286

Open
jerome73 opened this issue Jun 8, 2017 · 0 comments
Open

Reduce code duplication to support different ES versions #286

jerome73 opened this issue Jun 8, 2017 · 0 comments

Comments

@jerome73
Copy link
Contributor

jerome73 commented Jun 8, 2017

Expected behavior and actual behavior.

We have as many implementations of ES client service as there are versions of ES supported by logisland while the code is almost the same between versions i-e:
Elasticsearch_2_3_3_ClientService.java
Elasticsearch_2_4_0_ClientService.java
Elasticsearch_5_4_0_ClientService.java

The idea would be to avoid this code duplication that involves to support as many codes as there are versions of ES.

Steps to reproduce the problem.

Specifications like the version of the project, operating system, or hardware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant