This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Documents for Docker-compose #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
suggested changes
Apr 3, 2017
There was a problem hiding this comment.
@anisha1234 Thanks for your PR. I have a few suggestions for changes below.
README.md
Outdated
| @@ -36,10 +36,11 @@ To install the frontend please do the following: | |||
| 3. Install [ember-cli latest](https://www.npmjs.org/package/ember-cli): `npm install -g ember-cli@latest`. | |||
| Depending on your [npm permissions](https://docs.npmjs.com/getting-started/fixing-npm-permissions) you might need root access to install ember-cli. | |||
| 4. Install [bower](https://www.npmjs.org/package/bower): `npm install -g bower` | |||
| 5. Clone this repo with `git clone https://github.com/HospitalRun/hospitalrun-frontend`, go to the cloned folder and run `script/bootstrap`. | |||
| 5. Fork the master repository from `https://github.com/HospitalRun/hospitalrun-frontend` and clone the forked repository. | |||
There was a problem hiding this comment.
I'm not sure why the change here. For some folks cloning is all they will need to do.
README.md
Outdated
| @@ -75,13 +76,16 @@ To run HospitalRun with Docker please do the following: | |||
| - Build the HospitalRun image with `docker build -t hospitalrun-frontend .` | |||
| - Execute `docker run -it --name couchdb -d couchdb` to create the couchdb container. | |||
| - Execute `docker run -it --name hospitalrun-frontend -p 4200:4200 --link couchdb:couchdb -d hospitalrun-frontend` to create the HospitalRun container. | |||
| or instead, | |||
There was a problem hiding this comment.
The way this is formatted it isn't immediately clear that it is a different way to accomplish Running with Docker. I suggest breaking the Running With Docker into two sub sections, eg:
##Running With Docker
###Running With Docker Engine
Existing information here
###Running with Docker Compose
Your new info here
|
@jkleinsc I have changed the doc according to your suggestion.Kindly have a look at it |
jkleinsc
approved these changes
Apr 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #989
Changes proposed in this pull request:
cc @jkleinsc @jglovier @tangollama