Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

[TRACKING ISSUE] Color contrast problems in the UI #972

Closed
3 tasks
jglovier opened this issue Mar 6, 2017 · 11 comments
Closed
3 tasks

[TRACKING ISSUE] Color contrast problems in the UI #972

jglovier opened this issue Mar 6, 2017 · 11 comments
Assignees
Labels
in progress indicates that issue/pull request is currently being worked on ux wontfix indicates an issue/pull request will not be worked on

Comments

@jglovier
Copy link
Member

jglovier commented Mar 6, 2017

Expected behavior:
All text in the UI should pass at least WCAG AA contrast accessibility. A simple test of text-color on background color on this color accessibility calculator will tell whether any existing pairing of font on background passes. Many of our instances do, and a few do not.

Actual behavior:
Currently, there are a number of areas that need to improve to meet AA standard.
Including:

  • [add checklist of instances to address here]

Screenshots (if applicable):

Some offenders:


image


image


image


How to solve with tooling:

Some ways we can address this going forward are with tooling.

  • Establish a pattern library and styleguide that removes the possibility of introducing any new failing color styles
  • Add a test for contrast (will need to research options more)
@jglovier jglovier self-assigned this Mar 6, 2017
@jglovier jglovier added Accessibility help wanted indicates that an issue is open for contributions ux labels Mar 6, 2017
@jglovier
Copy link
Member Author

jglovier commented Mar 6, 2017

At this point what I could really use is some help with:

  1. identifying all of the offending font color contrast instances in the app
  2. suggesting replacement colors and implementing them
  3. testing to check for additions of new failing ront folor contrast

@jkleinsc
Copy link
Member

jkleinsc commented Mar 6, 2017

@jglovier thanks for putting this together. It is important work!

@anishaswain
Copy link
Contributor

anishaswain commented Mar 6, 2017

@jglovier I would also like to help you resolving the same issue

@jkleinsc
Copy link
Member

jkleinsc commented Mar 8, 2017

@anisha1234 please feel free to work on this issue. I'll mark it as in progress.

@jkleinsc jkleinsc added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Mar 8, 2017
@anishaswain
Copy link
Contributor

Thank you so much @jkleinsc . I will start working on it and keep you updated

@anishaswain
Copy link
Contributor

@jkleinsc @jglovier Should I make different PRs for changes in button style of different sections of the webapp for example - inventory , patients etc ?

@emadehsan
Copy link
Contributor

By the way @jglovier @anisha1234 have you considered usability for Color Blind People while choosing color schemes?

@anishaswain
Copy link
Contributor

@emadehsan what exactly do you want to be added for the same issue that you mentioned?

@emadehsan
Copy link
Contributor

As you guys are working hard on UI and UX 👍, I was just asking that Can a Colorblind person using the software distinguish between all the colors used throughout HospitalRun?

@anishaswain
Copy link
Contributor

@emadehsan @jglovier @jkleinsc In my current PR #983 , I have not considered the case of colour blind people.But I would surely like to work on it to make the colour scheme more user friendly .

@stale
Copy link

stale bot commented Aug 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix indicates an issue/pull request will not be worked on label Aug 7, 2019
@fox1t fox1t closed this as completed Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on ux wontfix indicates an issue/pull request will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants