Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Migrate from scss-lint to stylelint #443

Closed
5 tasks
jglovier opened this issue May 5, 2016 · 7 comments
Closed
5 tasks

Migrate from scss-lint to stylelint #443

jglovier opened this issue May 5, 2016 · 7 comments
Assignees
Labels
🚀enhancement an issue/pull request that adds a feature to the application

Comments

@jglovier
Copy link
Member

jglovier commented May 5, 2016

Scss-lint is giving us huge value in helping keep our CSS structured, consistent, and maintainable. The huge downside for our project, however, is that it requires Ruby, and as a Node based project that makes getting started for new contributors (especially Windows devs who don't have Ruby already installed on their machine) a significant barrier.

Scss-lint does have a Node ported version, but unfortunately it doesn't support all of the linters we need, including a few of the most valuable ones.

However, there is hope. And it's name is Stylelint. Stylelint appears to support everything that Scss-lint does, and has even more features. And best of all it is made for Node projects so it's way faster than Scss-lint (we've done some comparrison tests at GH and we are strongly considering moving from Scss-lint internally to Stylelint), and it would mean we no longer require Ruby for our app.

I'm strongly in favor of moving to Stylelint. Any objections?

cc @HospitalRun/core-maintainers


Notes:


TODO

  • Install Stylelint
  • Port scss-lint.yml rules to Stylelint config
  • Integrate Stylelint with Travis testing
  • Remove scss-lint
  • Remove ember-cli-scss-lint
@jglovier jglovier self-assigned this May 5, 2016
@jglovier jglovier added 🚀enhancement an issue/pull request that adds a feature to the application tracking-issue labels May 5, 2016
@jglovier jglovier added this to the HospitalRun 1.0 milestone May 5, 2016
@jkleinsc
Copy link
Member

jkleinsc commented May 5, 2016

@jglovier I'm fine with the change as long as it gets into the testing process with Travis. If we move to this we will also need to remove the ember-cli-scss-lint Ember addon.

@billybonks
Copy link
Contributor

Probably the best way to do this would be to build ember-cli-style-lint addon

@jglovier
Copy link
Member Author

also https://github.com/sasstools/sass-lint which is used by https://github.com/sir-dunxalot/ember-cli-sass-lint. pure node implementation.

@jkleinsc and I looked into switching to sass-lint at the hack week, but unfortunately it doesn't support a few key linting rules that we're getting with scss-lint.

@tangollama tangollama removed this from the HospitalRun 1.0 milestone May 13, 2016
@billybonks
Copy link
Contributor

so this is ready for use https://www.npmjs.com/package/ember-cli-style-lint

@jglovier
Copy link
Member Author

cc @jonrohan

@jonrohan
Copy link

jonrohan commented Jun 1, 2016

This is a pretty new package https://github.com/kristerkari/stylelint-scss/ that has a lot of scss specific rules for stylelint. A++ would recommend

@billybonks billybonks mentioned this issue Jun 2, 2016
15 tasks
@jglovier
Copy link
Member Author

jglovier commented Jun 3, 2016

Closed in #488.

@jglovier jglovier closed this as completed Jun 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application
Projects
None yet
Development

No branches or pull requests

5 participants