Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

[TRACKING ISSUE] Button styles are inconsistent at best, and ineffective and confusing at worst #359

Closed
3 tasks done
jglovier opened this issue Mar 16, 2016 · 6 comments
Closed
3 tasks done

Comments

@jglovier
Copy link
Member

jglovier commented Mar 16, 2016

TRACKING LIST:

Expected experience: Button styles in the app should be consistent, and should help indicate what their function is.

Actual experience: Button styles are wildly inconsistent, and often very confusing. For example:

  • The styles for disabled buttons do not clearly convey that they are disabled.
  • Hover states are unhelpful and confusing (some buttons get darker on hover, some get lighter on hover, and others change color entirely on hover).
  • In some places buttons are inconsistent in width.
  • Where there should be only one primary call to action, in some places there are up to three.
  • Alignment of buttons is inconsistent (in some views they are left aligned, while in others they are right aligned)

Screenshots:

hospitalrun-buttons

image

image

@jglovier
Copy link
Member Author

Interesting idea from @dswanson via #361 (comment)

Another affordance I have seen work is to de-emphasize the actions except when the specific row has focus.

When the user "selects" the row, that row is highlighted and then the actions are made more apparent.
This can be done by making the actions invisible until the highlighting, or just changing their opacity.

@tangollama
Copy link
Member

@jglovier is this still relevant? If so, can we make it a HackDay issue?

@aayushsanghavi
Copy link

Sir, I would like to take up this issue. I am new to open source so your guidance would be appreciated.
Could you tell me where to start from and which files have these issues.

@jkleinsc
Copy link
Member

jkleinsc commented Oct 5, 2016

@aayushsanghavi thank you for your interest. I believe this issue was mislabeled for hacktoberfest as I'm not sure there is anything to do here.

@jglovier isn't this a tracking issue vs a specific issue that folks can work on? Not sure why it has the hacktoberfest label on it.

@Lily418
Copy link

Lily418 commented Jul 19, 2018

Looks like the final item in the checklist has been closed by #983 I think this can now be closed?

@donaldwasserman
Copy link
Contributor

@Lily418 Thanks, looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants