Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

New Lab Request - required visit not enforced #2557

Open
blestab opened this issue Jan 27, 2021 · 2 comments · May be fixed by #2559
Open

New Lab Request - required visit not enforced #2557

blestab opened this issue Jan 27, 2021 · 2 comments · May be fixed by #2559
Assignees
Labels
🐛bug issue/pull request that documents/fixes a bug in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module
Milestone

Comments

@blestab
Copy link
Contributor

blestab commented Jan 27, 2021

This is a follow-up to #2551 (see #2552 (review) ) and can only be started once the linked PR has been merged in.

When requesting a new lab, visit is required but a user can still save without choosing a visit.

🐛 Bug Report

When creating a new lab request, a user should not be able to save without specifying a visit.

To Reproduce

Go to staging https://staging.hospitalrun.io/
Create a new patient and create one visit for this patient
Create a new lab request leaving the visit field empty
Notice you are allowed to save even though the visit is marked as required

Expected behavior

User should not be able to save a New Imaging request without selecting a visit.

Reference

See how the Patient or Type field are handled and do the same

Your Environment

  • node version: 6,8,10
  • fastify version: >=1.0.0
  • os: Mac, Windows, Linux
  • any other relevant information
@blestab blestab added 🐛bug issue/pull request that documents/fixes a bug help wanted indicates that an issue is open for contributions labs issue/pull request that interacts with labs module 🚧blocked issue cannot be worked on for some reason labels Jan 27, 2021
@blestab blestab added this to the v2.0 milestone Jan 27, 2021
@SamuelQZQ
Copy link
Contributor

@blestab Can I be assigned to this task?

@blestab
Copy link
Contributor Author

blestab commented Jan 27, 2021

@blestab Can I be assigned to this task?

All yours @SamuelQZQ

@blestab blestab added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions 🚧blocked issue cannot be worked on for some reason labels Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛bug issue/pull request that documents/fixes a bug in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module
Projects
None yet
2 participants