Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Medication: New medication request quantity amount and unit not creating correctly #2492

Closed
blestab opened this issue Dec 5, 2020 · 8 comments · Fixed by #2554
Closed

Medication: New medication request quantity amount and unit not creating correctly #2492

blestab opened this issue Dec 5, 2020 · 8 comments · Fixed by #2554
Assignees
@chadian @hd-genius
Labels
🐛bug issue/pull request that documents/fixes a bug in progress indicates that issue/pull request is currently being worked on LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) medication issue/pull request that interacts with medication module
Projects
Version 2.0
Milestone
v2.0

Comments

@blestab
Copy link
Contributor

blestab commented Dec 5, 2020 •
edited
Loading

🐛 Bug Report

When a new medication request is created, the quantity (value and unit) do not seem to be created correctly.
This leads to the edit/view form not displaying the quantity value and unit.
Editing however works as expected.

To Reproduce

Steps to reproduce the behavior:

  • Access staging: https://staging.hospitalrun.io/
  • Create a new medication request, specifying a quantity amount and unit. NOTE: You may have to create a patient first if none exists.
  • Go to the medication requests listing
  • View the request you just created and notice the Quantity just displays "x" instead of amount x unit e.g. "15 x TAB"

image

image

Expected behavior

  • New medication request should correctly update the quantity amount and unit when saving such the the display and edit screen can also access these values e.g. editing the above example to Quantity amount 30, unit CAPSULE, correctly updates the model
  • See how edit request correctly updates these and fix the request medication functionality to do the same thing.

image

image

Your Environment

  • node version: 6,8,10
  • fastify version: >=1.0.0
  • os: Windows
  • any other relevant information
@blestab blestab added 🐛bug issue/pull request that documents/fixes a bug help wanted indicates that an issue is open for contributions LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) medication issue/pull request that interacts with medication module labels Dec 5, 2020
@blestab blestab added this to the v2.0 milestone Dec 5, 2020
@blestab blestab added this to To do in Version 2.0 via automation Dec 5, 2020
@hd-genius
Copy link
Contributor

I'd be interested in working on this bug.

@blestab
Copy link
Contributor Author

blestab commented Dec 6, 2020

sure @roy-stewart , thanks

@blestab blestab added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Dec 6, 2020
@blestab blestab changed the title Medication: New medication request quantity amount and unit not creating correctly Medications: New medication request quantity amount and unit not creating correctly Dec 6, 2020
@blestab blestab changed the title Medications: New medication request quantity amount and unit not creating correctly Medication: New medication request quantity amount and unit not creating correctly Dec 6, 2020
@blestab
Copy link
Contributor Author

blestab commented Jan 5, 2021

Hi @roy-stewart , compliments of the season and best wishes for 2021!
Just checking how this work is going.

@chadian chadian mentioned this issue Jan 26, 2021
Merged
@chadian
Copy link
Contributor

chadian commented Jan 26, 2021

Hello @roy-stewart not sure if you're still working on this but I spiked on a fix that's almost finished in #2554. If you have something else in mind I'd love to collaborate and check it out.

@blestab
Copy link
Contributor Author

blestab commented Jan 26, 2021

Hello @roy-stewart not sure if you're still working on this but I spiked on a fix that's almost finished in #2554. If you have something else in mind I'd love to collaborate and check it out.

Thank you @chadian
I had a quick look at the PR it seems to resolve the issue. I have put this onto your name.

@hd-genius
Copy link
Contributor

Sorry for the late response. I've been having issues with building and running HospitalRun on my computer for several weeks now so I haven't had a chance to finish the bug fix for this. Thanks for helping look into this @chadian!

@chadian
Copy link
Contributor

chadian commented Jan 26, 2021

All good @roy-stewart. If you'd like some help we can pair on getting your environment working, feel free to ping me on the hospital run slack.

@blestab
Copy link
Contributor Author

blestab commented Jan 27, 2021

Sorry for the late response. I've been having issues with building and running HospitalRun on my computer for several weeks now so I haven't had a chance to finish the bug fix for this. Thanks for helping look into this @chadian!

That's alright @roy-stewart, thanks for helping out @chadian #TogetherWeCan

image

Version 2.0 automation moved this from To do to Done Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chadian chadian

@hd-genius hd-genius

Labels
🐛bug issue/pull request that documents/fixes a bug in progress indicates that issue/pull request is currently being worked on LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) medication issue/pull request that interacts with medication module
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

fix(medication): set correct quantity and value for new medications chadian/hospitalrun-frontend
3 participants
@chadian @blestab @hd-genius