Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Ability to view a diagnosis #2129

Closed
jackcmeyer opened this issue Jun 16, 2020 · 13 comments 路 Fixed by codethechange/hospitalrun-frontend#2 or #2504
Closed

Ability to view a diagnosis #2129

jackcmeyer opened this issue Jun 16, 2020 · 13 comments 路 Fixed by codethechange/hospitalrun-frontend#2 or #2504
Labels
馃殌enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) patients issue/pull request that interacts with patients module
Projects
Version 2.0
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

馃殌 Feature Proposal

Currently, the list of diagnosis are not clickable. This issue is to make them clickable and create a component that allows a user to view the diagnoses.

Technical notes

  • the routing should work similar to how care plan routes work
@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Jun 16, 2020
@jackcmeyer jackcmeyer added good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions 馃殌enhancement an issue/pull request that adds a feature to the application labels Jun 16, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Jun 16, 2020
@doptster
Copy link

Hi, @jackcmeyer I would like to try this issue.

I have a question though, it seems that the diagnoses has only 2 fields which are diagnosis name and date, as compared to care plans which has much more existing fields, do you think the "View" button is necessarily in this case? Since we could be showing the 2 fields in the table row by default.

@matteovivona matteovivona added in progress indicates that issue/pull request is currently being worked on and removed good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions labels Jun 16, 2020
@blestab
Copy link
Contributor

blestab commented Jun 16, 2020

Hi @dopt
Additional fields are being added to diagnosis via #2128 hence the need for this ability, I think.

@reidmeyer
Copy link
Contributor

Yup, I'm working on #2128, so I can tackle this once I'm done there since this is directly related.

@jackcmeyer
Copy link
Member Author

jackcmeyer commented Jun 17, 2020 •
edited
Loading

Hi, @jackcmeyer I would like to try this issue.

I have a question though, it seems that the diagnoses has only 2 fields which are diagnosis name and date, as compared to care plans which has much more existing fields, do you think the "View" button is necessarily in this case? Since we could be showing the 2 fields in the table row by default.

@blestab answered the question perfectly.

Also, there will eventually be some sort of workflow for a diagnosis which will need the ability to view a diagnosis.

@jackcmeyer jackcmeyer added the patients issue/pull request that interacts with patients module label Jun 17, 2020
@doptster
Copy link

@blestab @jackcmeyer Got it, thanks.
It's better to wait for #2128 to be finished first since both issues are linked.

Also, there will eventually be some sort of workflow for a diagnosis which will need the ability to view a diagnosis.

For now, I will probably reuse care plans' workflow for diagnoses, do let me know if there's different opinion on the matter.

@reidmeyer I can take care of this issue once #2128 is done, don't worry about that.

@jackcmeyer jackcmeyer added help wanted indicates that an issue is open for contributions and removed in progress indicates that issue/pull request is currently being worked on labels Jul 8, 2020
@jackcmeyer jackcmeyer added the LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) label Jul 29, 2020
@reidmeyer
Copy link
Contributor

@dopt #2128 is done. Just wanted to update you in case you wanted to get reassigned to this issue.

@danikyl
Copy link

danikyl commented Aug 19, 2020

Hi guys, I'd like to handle this one!

@jackcmeyer
Copy link
Member Author

Hi guys, I'd like to handle this one!

Go for it @danikyl!

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Aug 20, 2020
@morrme
Copy link
Member

morrme commented Sep 7, 2020

Hi @danikyl ! What is the current status of your work on this issue? Can we help in any way?

@danikyl
Copy link

danikyl commented Sep 9, 2020

Hi @danikyl ! What is the current status of your work on this issue? Can we help in any way?

Hello there! Sorry for the delay. I need 5 more days to complete this work.

@fox1t
Copy link
Member

fox1t commented Sep 10, 2020

Hi @danikyl ! What is the current status of your work on this issue? Can we help in any way?

Hello there! Sorry for the delay. I need 5 more days to complete this work.

No worries! And thanks for looking into this! :)

@anthonyaperez
Copy link
Contributor

Hi @jackcmeyer @fox1t @tehkapa, I would love to take this issue on if it's still open.

@jackcmeyer
Copy link
Member Author

Hi @jackcmeyer @fox1t @tehkapa, I would love to take this issue on if it's still open.

Go for it!

@anthonyaperez anthonyaperez mentioned this issue Dec 5, 2020
Merged
@anthonyaperez anthonyaperez mentioned this issue Dec 7, 2020
Merged
Version 2.0 automation moved this from To do to Done Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
馃殌enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) patients issue/pull request that interacts with patients module
Projects
Version 2.0
  
Done
Milestone
v2.0
9 participants
@fox1t @doptster @blestab @matteovivona @reidmeyer @jackcmeyer @anthonyaperez @morrme @danikyl