Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(billing): create a basic billing module #2528

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

rsousaj
Copy link
Contributor

@rsousaj rsousaj commented Dec 22, 2020

Fixes #2496

Changes proposed in this pull request:

  • created PricingItem model;
  • created PricingItemRepository
  • created hooks using react-query
  • created Views and added sidebar links

I've tried to strict follow what was requested but I'm all ears for reviews.

@vercel
Copy link

vercel bot commented Dec 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/34t7a9kgn
✅ Preview: https://hospitalrun-frontend-git-fork-rsousaj-2496-billing-module.hospitalrun.vercel.app

@blestab blestab changed the title Basic billing module feat(billing): create a basic billing module Dec 22, 2020
@blestab
Copy link
Contributor

blestab commented Dec 22, 2020

Thanks @rsousaj looking good so far. Just a couple of requests:

  • Add "New Pricing Item" to the quick create button in the Navbar as the last item
    image

  • The Notes field must be a textarea not a textbox
    image

  • Creating a new pricing item errors out if a user entered a preformatted number e.g. 4,500
    image

src/__tests__/billing/hooks/useAddPricingItem.test.tsx Outdated Show resolved Hide resolved
src/__tests__/billing/hooks/useAddPricingItem.test.tsx Outdated Show resolved Hide resolved
src/shared/model/Permissions.ts Outdated Show resolved Hide resolved
src/shared/model/Permissions.ts Outdated Show resolved Hide resolved
src/shared/locales/enUs/translations/billing/index.ts Outdated Show resolved Hide resolved
src/shared/config/pouchdb.ts Outdated Show resolved Hide resolved
src/shared/components/Sidebar.tsx Show resolved Hide resolved
src/__tests__/billing/hooks/useUpdatePricingItem.test.tsx Outdated Show resolved Hide resolved
@rsousaj
Copy link
Contributor Author

rsousaj commented Dec 22, 2020

Thanks @blestab

I'll working on changes right now

blestab
blestab previously approved these changes Dec 24, 2020
@blestab
Copy link
Contributor

blestab commented Dec 24, 2020

Thank you @rsousaj, the price field handling is looking good. Will wait to hear what the rest of the team thinks.

Basic billing LGTM. We will maybe open a separate issue once the billing icon is ready to update the icon to the correct one

@rsousaj
Copy link
Contributor Author

rsousaj commented Dec 24, 2020

Thank you @rsousaj, the price field handling is looking good. Will wait to hear what the rest of the team thinks.

Basic billing LGTM. We will maybe open a separate issue once the billing icon is ready to update the icon to the correct one

Thanks! I'm learning so much here, it has been an amazing experience. In case of any need, just let me know.

@blestab
Copy link
Contributor

blestab commented Dec 30, 2020

Thank you @rsousaj, the price field handling is looking good. Will wait to hear what the rest of the team thinks.
Basic billing LGTM. We will maybe open a separate issue once the billing icon is ready to update the icon to the correct one

Thanks! I'm learning so much here, it has been an amazing experience. In case of any need, just let me know.

That's great to know @rsousaj, will do. Thanks for helping us with this.

@blestab blestab added billing in progress indicates that issue/pull request is currently being worked on LOE - large indicates that the level of effort to complete issue is large 🚀enhancement an issue/pull request that adds a feature to the application labels Dec 30, 2020
@blestab blestab added this to the v2.0 milestone Dec 30, 2020
@CLAassistant
Copy link

CLAassistant commented Jan 30, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ tehKapa
✅ rsousaj
❌ blestab
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
billing 🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on LOE - large indicates that the level of effort to complete issue is large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a basic billing module
4 participants