Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Patient View: Diagnoses section headings height fix #2440

Closed
blestab opened this issue Oct 24, 2020 · 4 comments · Fixed by #2456
Closed

Patient View: Diagnoses section headings height fix #2440

blestab opened this issue Oct 24, 2020 · 4 comments · Fixed by #2456
Assignees
@gustavoplenamente
Labels
🐛bug issue/pull request that documents/fixes a bug hacktoberfest in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
Version 2.0
Milestone
v2.0

Comments

@blestab
Copy link
Contributor

blestab commented Oct 24, 2020 •
edited

🐛 Bug Report

Diagnoses section headers should be the same height as Care Plans headers

To Reproduce

On https://staging.hospitalrun.io/

  1. Login and go to patients,
  2. Select an existing patient to view or create a new one if no patients already exist, then view the patient
  3. Notice the Diagnoses section's header is not the same height as that for the Care Plans

image

Expected behavior

Diagnoses and Care Plans headings should be the same height. To achieve this,

  1. Change "Diagnosis Name" to just "Name" and make sure the heights now match; if not, adjust the Diagnoses headings row height appropriately.
  2. For consistency also change "Diagnosis Date" to just "Date"

image

Your Environment

  • node version: 6,8,10
  • fastify version: >=1.0.0
  • os: Mac, Windows, Linux
  • any other relevant information
@blestab blestab added help wanted indicates that an issue is open for contributions patients issue/pull request that interacts with patients module hacktoberfest labels Oct 24, 2020
@blestab blestab added this to the v2.0 milestone Oct 24, 2020
@blestab blestab added this to To do in Version 2.0 via automation Oct 24, 2020
@blestab blestab added the 🐛bug issue/pull request that documents/fixes a bug label Oct 25, 2020
@gustavoplenamente
Copy link
Contributor

May I be assigned to this issue?

@blestab blestab added hacktoberfest-accepted in progress indicates that issue/pull request is currently being worked on and removed hacktoberfest help wanted indicates that an issue is open for contributions labels Oct 25, 2020
@blestab
Copy link
Contributor Author

blestab commented Oct 25, 2020

Thanks @gustavoplenamente

I have put this on your name.

@gustavoplenamente
Copy link
Contributor

gustavoplenamente commented Oct 26, 2020 •
edited

@blestab , the description says to change from "Diagnosis Name" to just "Diagnosis" but the example image is different. It changes "Diagnosis Name" to just "Name".
As it seems more appealing to me, I will change to just "Name", as the table name already tells the user it's about diagnoses.

@blestab
Copy link
Contributor Author

blestab commented Oct 26, 2020

@blestab , the description says to change from "Diagnosis Name" to just "Diagnosis" but the example image is different. It changes "Diagnosis Name" to just "Name".
As it seems more appealing to me, I will change to just "Name", as the table name already tells the user it's about diagnoses.

Thanks for picking this up, i have corrected the description.

In summary we want to make the following changes:
Diagnosis Name => Name
Diagnosis Date => Date

@gustavoplenamente gustavoplenamente mentioned this issue Oct 26, 2020
Merged
Version 2.0 automation moved this from To do to Done Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gustavoplenamente gustavoplenamente

Labels
🐛bug issue/pull request that documents/fixes a bug hacktoberfest in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

fix(i18n): add diagnosis translations gustavoplenamente/hospitalrun-frontend
3 participants
@blestab @matteovivona @gustavoplenamente