Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

WIP: refactor(create patient): use react-query when creating a patient #2467

Closed
wants to merge 2 commits into from
Closed

WIP: refactor(create patient): use react-query when creating a patient #2467

wants to merge 2 commits into from

Conversation

giulianovarriale
Copy link
Contributor

@giulianovarriale giulianovarriale commented Oct 31, 2020 •
edited
Loading

Fixes #2378.

Changes proposed in this pull request:

  • Use react-query for creating a new patient
  • Remove redux code that was used for creating a new patient

@jsf-clabot
Copy link

jsf-clabot commented Oct 31, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gitpod-io
Copy link

gitpod-io bot commented Oct 31, 2020 •
edited
Loading

@vercel
Copy link

vercel bot commented Oct 31, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/1lugl09zk
✅ Preview: https://hospitalrun-frontend-git-refactor-create-patient.hospitalrun.vercel.app

@giulianovarriale giulianovarriale marked this pull request as ready for review October 31, 2020 21:20
@giulianovarriale
Copy link
Contributor Author

The PR is not finished yet, I opened it already for two reasons:

  1. I'm participating in hacktoberfest and today is the last day to contribute.
    Anyway, I'll finish my contribution because this is the right thing to do and also I'm having fun implementing react-query on the project.
  2. I'm wondering what you expect to be tested in here, since the feature remains the same, but the implementation has been changed. For this PR, I was thinking to write a test for the validator and also a test for the hook, what do you think?

@giulianovarriale giulianovarriale mentioned this pull request Oct 31, 2020
Closed
@matteovivona matteovivona changed the title refactor(create patient): use react-query when creating a patient WIP: refactor(create patient): use react-query when creating a patient Oct 31, 2020
@matteovivona matteovivona added hacktoberfest-accepted in progress indicates that issue/pull request is currently being worked on labels Oct 31, 2020
@giulianovarriale giulianovarriale deleted the refactor/create-patient branch June 1, 2021 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackcmeyer jackcmeyer Awaiting requested review from jackcmeyer

@fox1t fox1t Awaiting requested review from fox1t

Assignees
No one assigned
Labels
hacktoberfest-accepted in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create useCreatePatient react-query hook and remove redux create patient code
3 participants
@giulianovarriale @jsf-clabot @matteovivona