Investigate usage of 'react/require-default-props' & 'react/default-props-match-prop-types'

[jackcmeyer]

Recently, the following was added to the .eslintrc.js file to warn about new linting rules.

    'react/require-default-props': ['warn'],
    'react/default-props-match-prop-types': ['warn']

It seems like these should be errors, however, more research should be done. This issue is to investigate the new rules.

If the rules should be errors, then this issue will require code changes to conform to the new lint rules.

If the rules should be turned off, then only configuration changes will be necessary.

[matteovivona]

Link FE-494

[YimniChan]

Could I get assign to work on this?

[jackcmeyer]

@YimniChan I've assigned this to you.

[YimniChan]

The react/require-default-props rule should be an error.
If we do not set any default props, the undefined display should take place of the props that are not sent by the parent component. In execution, an undefined variable may cause the application to break if it is used and there are no safety precautions in place. We do not want that to occur. Furthermore, we should set a defaultProps value, and when a prop is missing, the defaultProps value will replace the undefined.

The react/default-props-match-prop-types rule should be turned off.
In the naming convention used in code, variable names usually have the same name as its props variable, even if they are not in the same file. PropTypes exports are for validating the data type is match and valid. Look like the default-props-match-prop-types is a kind of fixed shape. It seems not necessary in this case. Furthermore, projects have interfaces that provide the benefit of type-checking values shape. The props that are passed around normally follow interface rules. Interface set or applies the requirement properties and their type. When we try to use the properties for the variable, the system just checks did the object we pass to the function meets the requirements listed. The interface can be extended and changed to fit the need of the application, Prop types of the default drop might be changing while calling by different functions.

[matteovivona]

@fox1t