This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
WIP - Add ability to create a patient when adding a related person that does not exist #2207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2106 .
Changes proposed in this pull request:
Created 2 new components for Related Person tab (Dashboard > Patient > Related Person): AddNewRelatedPanel (replaces AddNewRelatedModal), and CreateRelatedPersonPanel (adds New Patient creation functionality)
Modified RelatedPerson tab to implement these new components as per user story here: Ability to create a patient when adding a related person that does not exist #2106 (comment)
Current Functionality:
Required functionality:
Basically, the two Relationship Type fields should be synced, either in realtime or when either Save button is pressed, as should the respective Related Person and Given Name fields. If point 1 of the required functionality is achieved, then this only needs to happen in one direction, from AddNewRelatedPanel to CreateRelatedPersonPanel.
I'm submitting the PR at this stage as while I can see some ways to achieve the goals, such as adding referral props to the patient model, but that starts to seem a little messy and I'd mainly like some feedback on the following:
General tips and advice also welcome!