-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
A button for switch between language... #1094
Comments
Thanks @jujes. This is a missing feature and one that someone in the community could (relatively) quickly tackle. I'll label appropriately. |
@tangollama I don't have a good sense of the changes required to implement this, but I'm pretty keen to learn. I have a fair amount of questions before getting started though. |
A global config for the default and a user preference are in order.
Typed or dictated imperfectly on my iPhone (717.385.9970)
… On Jun 7, 2017, at 11:22 AM, Richie Thomas ***@***.***> wrote:
Should the language settings be stored as an attribute of the user, so they persist with each user session?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@richiethomas |
@tchan yeah looks like that's currently a dependency of the project. I'll definitely need to read through the package documentation as part of playing this story. @tangollama since there's no design spec to work off, is there a certain location where the language toggle should go? Or should I just come up with something and submit it for consideration? My first thought was adding a select element to the dropdown that appears when clicking the "Settings" gear. |
I think that's a great recommendation on the gear location. Perhaps @jglovier can offer some guidance as well.
… On Jun 8, 2017, at 10:04 AM, Richie Thomas ***@***.***> wrote:
@tchan yeah looks like that's currently a dependency of the project. I'll definitely need to read through the package documentation as part of playing the story.
@tangollama since there's no design spec to work off, is there a certain location where the language toggle should go? Or should I just come up with something and submit it for consideration? My first thought was adding a select element to the dropdown that appears when clicking the "Settings" gear.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Thanks @tangollama. Follow-up question- in the past I've used an npm package called More info here- https://github.com/cibernox/ember-power-select If you'd rather I just hard-code the languages for now so the dependency decision can be postponed, I could also do that. |
@richiethomas I would prefer to not add another select component to the project. We currently use ember-rapid-forms which has a select component (em-select) and there also is a another component, ember-select-list, in the project. |
@jkleinsc gotcha, wasn't aware of those other 2 dependencies. I'll investigate those instead. |
@jkleinsc I'm running into problems with the navigation.js mixin. When I toggle the language in my dropdown menu, the change propogates to the i18n service, which causes all the relevant components to re-render except for the sidebar navigation. This is because the text values for these elements are populated by the I don't see any authorization logic (i.e. |
@richiethomas I think you need As far as localizedNavItems is concerned, it is an artifact to the way the navigation was localized. I would be happy if we changed the navigation to define translation keys instead of text that gets automagically translated. There really isn't a good reason for it being the way it is right now. |
@jkleinsc yep, As for If you're not sure off the top of your head, don't worry about it. I've committed the working version to my local and so I'm free to mess around until I get the refactoring right. :-) |
@richiethomas That sounds correct to me. I would also verify that there isn't anything funky in the tests with those, but I would just make the change and then just verify if the tests are passing. |
@jkleinsc cool, thanks. Going back to the |
@richiethomas good question. Yes, this is the way Ember works. I think (my own 2c) there is a good reason why: computed properties are cached and are only recalculated when the dependent keys change. If it went deep on an object every time anything changed on the object, that means that the computed property would be unnecessarily recalculated on every change, instead of just focusing on the changes that the computed property depended on. If you had a rather large object you could up needlessly recalculating endlessly. Having said that, there is a way in Ember to work with aggregate data in computed properties: |
Awesome, that makes sense now. Thanks for that, and I'll take a look at the link. |
@jkleinsc since the code for this feature has been solely on my machine for awhile, I'd like to try to get the initial version (before refactoring out the |
@richiethomas I wholeheartedly agree. Smaller PRs are much easier to review. |
P.S.- ignore the |
To address the original issue that prompted @jujes to report this- the |
@richiethomas missing translations should be filed as separate issues so that we can solicit folks with good understanding of the language to be translated to work on them. |
Resolved by #1109. |
Expected behavior:
option to switch from English to Spanish
Actual behavior:
No Spanish language as choice
Hi, someone know how I can make available the Spanish has a choice for user interface?
thanks in advance,
The text was updated successfully, but these errors were encountered: