Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Select - add the ability to display error messages #689

Closed
blestab opened this issue Feb 2, 2021 · 2 comments · Fixed by #690
Closed

Select - add the ability to display error messages #689

blestab opened this issue Feb 2, 2021 · 2 comments · Fixed by #690
Assignees
Labels
Projects

Comments

@blestab
Copy link

blestab commented Feb 2, 2021

Add the ability to display messages beneath the Select component

🚀 Feature Proposal

Add the ability to display messages e.g. beneath the Select component, like how the TextInput does. See this discussion: HospitalRun/hospitalrun-frontend#2559 (comment)

Motivation

There is a need to be able to display messages (error or help) beneath the component
Update storybook as needed

Example

See how the TextInput displays an error message below it while the Select doesn't

image

@blestab blestab added enhancement New feature or request help wanted Extra attention is needed labels Feb 2, 2021
@blestab blestab added this to To do in Version 2.0 via automation Feb 2, 2021
@SamuelQZQ
Copy link
Contributor

Hey @blestab, you can assign this to me.

@blestab blestab added in progress and removed help wanted Extra attention is needed labels Feb 2, 2021
Version 2.0 automation moved this from To do to Done Feb 4, 2021
@ghost
Copy link

ghost commented Feb 4, 2021

🎉 This issue has been resolved in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Version 2.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants