Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dafny 4.1.0 #130682

Closed
wants to merge 7 commits into from
Closed

dafny 4.1.0 #130682

wants to merge 7 commits into from

Conversation

tchajed
Copy link
Contributor

@tchajed tchajed commented May 10, 2023

Created with brew bump-formula-pr.

release notes
## New features

Bug fixes

@tchajed
Copy link
Contributor Author

tchajed commented May 10, 2023

I'm trying a couple fixes to this formula:

  • I don't believe Dafny requires dotnet 6, so let's try bumping it to dotnet 7 (the latest). I opened Does Dafny support dotnet 7? dafny-lang/dafny#3992 to get confirmation on this.
  • There shouldn't be any real dependence on Java unless you're compiling from Dafny to Java. At best this is an optional dependency. It could also be bumped to openjdk@19, and that formula would need to be added to Homebrew.

If these fixes shouldn't be mixed in with a version bump I'm happy to open a separate PR (we should be able to do the version bump first).

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. bump-formula-pr PR was created using `brew bump-formula-pr` dotnet .NET use is a significant feature of the PR or issue labels May 10, 2023
@github-actions github-actions bot added the java Java use is a significant feature of the PR or issue label May 10, 2023
Formula/dafny.rb Outdated Show resolved Hide resolved
Formula/dafny.rb Show resolved Hide resolved
@tchajed
Copy link
Contributor Author

tchajed commented May 10, 2023

Looks like these changes fail in CI (though they seemed to work locally) so I've reverted them.

SMillerDev
SMillerDev previously approved these changes May 11, 2023
@carlocab carlocab requested a review from p-linnane May 11, 2023 09:06
fxcoudert
fxcoudert previously approved these changes May 11, 2023
@github-actions
Copy link
Contributor

🤖 An automated task has requested creation of a replacement PR.

@github-actions github-actions bot dismissed stale reviews from SMillerDev and fxcoudert May 11, 2023 12:22

Replacement PR dispatched

BrewTestBot pushed a commit that referenced this pull request May 11, 2023
* dafny 4.1.0
* dafny: simplify dependencies
* dafny: add back openjdk
* Make sure to use dotnet formula
* dafny: update tests
* dafny: switch back to dotnet@6
* dafny: fix test

Closes #130682.

Signed-off-by: BrewTestBot <[email protected]>
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request superseded PR was replaced by another PR labels May 11, 2023
@github-actions
Copy link
Contributor

✅ Replacement PR created at #130730.

BrewTestBot added a commit that referenced this pull request May 11, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. bump-formula-pr PR was created using `brew bump-formula-pr` dotnet .NET use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue outdated PR was locked due to age superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants