Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify + improve code in general. #57

Open
mcw92 opened this issue Jul 25, 2023 · 0 comments
Open

Beautify + improve code in general. #57

mcw92 opened this issue Jul 25, 2023 · 0 comments
Assignees

Comments

@mcw92
Copy link
Contributor

mcw92 commented Jul 25, 2023

  • Replace unnecessary list comprehensions with generators.
  • Consistently use numpy arrays / lists or rather just request an "indexable" object in the user interface via Union[list, np.array, python array, xarray]). Create new type Indexable with typing.
  • Defaults of integers should not be None; rather -1 or 0.
  • In __eq__(): If I check for equality of different types, just return False and do not use assert(). if not isinstance: return False
@mcw92 mcw92 self-assigned this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant