Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use "master_seed"! master_seed "False" in config, users.json without master_seed will result in "siteSign" failure, missing auth_addresses in users.json, updates not working!! :/ #2512

Open
ghost opened this issue Apr 8, 2020 · 8 comments

Comments

@ghost
Copy link

ghost commented Apr 8, 2020

Traceback (most recent call last):
  File "zeronet.py", line 17, in main
    main.start()
  File "/opt/zero/src/main.py", line 589, in start
    actions.call(config.action, action_kwargs)
  File "/opt/zero/src/main.py", line 123, in call
    back = func(**kwargs)
  File "/opt/zero/src/main.py", line 206, in siteSign
    site_data = user.getSiteData(address)
  File "/opt/zero/src/User/User.py", line 78, in getSiteData
    self.generateAuthAddress(address)
  File "/opt/zero/src/util/Noparallel.py", line 57, in wrapper
    raise(err)
  File "/opt/zero/src/util/Noparallel.py", line 50, in wrapper
    res = func(*args, **kwargs)
  File "/opt/zero/src/User/User.py", line 63, in generateAuthAddress
    auth_privatekey = CryptBitcoin.hdPrivatekey(self.master_seed, address_id)
  File "/opt/zero/src/Crypt/CryptBitcoin.py", line 69, in hdPrivatekey
    masterkey = btctools.bip32_master_key(bytes(seed, "ascii"))
TypeError: encoding without a string argument

I urge everyone who using ZeroNet not to use "master_seed" at all! @HelloZeroNet and @imachug working on Windows and Google Chrome and they have been notified prior to turn "master_seed" off!

@purplesyringa
Copy link
Contributor

absolutely bullshit this master seed shit, now you gonna fix this genius

It helps to recover your private keys. You can always disable master seed if you don't want to. Also, creating sites via terminal was never recommended and the modification only changed the behavour when using console, not browser UI, so saying that this change affected users much is wrong. And if you know how to use terminal, perhaps you know how to fix users.json as well (how the heck did master_seed manage to corrupt it though?).

@ghost
Copy link
Author

ghost commented Apr 8, 2020

@imachug I only want site address and privatekey in users.json which is not possible. If master_seed is turned off than siteSign will fail!

@purplesyringa
Copy link
Contributor

If master_seed is turned off than siteSign will fail!

Are you talking about CLI siteSign command or ZeroNet UI?

@ghost
Copy link
Author

ghost commented Apr 8, 2020

CLI

@ghost ghost changed the title Don't use "master_seed", if Tamas Kocsis turn it on, you should turn it off! Don't use "master_seed"! master_seed "False" in config, users.json without master_seed will result in "siteSign" failure :/ Apr 8, 2020
@ghost
Copy link
Author

ghost commented Apr 8, 2020

@imachug
notcool

@ghost
Copy link
Author

ghost commented Apr 8, 2020

@HelloZeroNet @imachug okay, now my log is full of messages regarding auth_address, no other than 1Hello has auth_address in my users.json. 🙄

Is there any way to generate those auth_addresses? 🤔

Please turn off master_seed, if user need than it should request that. users.json seems all the time have master_seed even if in config that is turned off. Removing master_seed from users.json manually will result again in failure of siteSign. Additionally, I don't see any option to regenerate auth_address and so the log is filled with error messages.

example:
KeyError: 'auth_address' in UiWebsocket.py line 79 > UiWebsocket.py line 232 > UiWebsocket.py line 348 > Newsfeed/NewsfeedPlugin.py line 14 > UiWebsocket.py line 264 > User.py line 115 {"cmd":"siteInfo","params":{},"id":1000001}

updates not working and because auth_address is missing not even see the sites in UI...

@ghost ghost changed the title Don't use "master_seed"! master_seed "False" in config, users.json without master_seed will result in "siteSign" failure :/ Don't use "master_seed"! master_seed "False" in config, users.json without master_seed will result in "siteSign" failure, missing auth_addresses in users.json, updates not working!! :/ Apr 8, 2020
@ghost
Copy link
Author

ghost commented Apr 9, 2020

sitePublish also doesn't work!!! Congratulations @HelloZeroNet @shortcutme @imachug @filips123 you just destroyed ZeroNet with your stupid "master_seed" mania!

Again, turn off master_seed! Clean up users.json and encourage everyone to BACK UP PRIVATEKEYS!

@purplesyringa
Copy link
Contributor

Clean up users.json and encourage everyone to BACK UP PRIVATEKEYS!

We already do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant