Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior
When compiling with
-D js-classic
and using (chrome/vscode/nwjs) javascript debugger, when$hxClasses
are generated (this behavior can be forced with-dce no
for example) we end up with weird type names in debugger:This is because javascript debugger trips on this expression while generating a function name:
When also using
-D js-unflatten
, we get an even worse variant:This is because javascript debugger trips on this expression while generating a function name:
Proposed solution
In order to avoid js debugger messing up function (and so types) names, and since support for
displayName
has been removed, we need to clean up that function declaration and move the$hxClasses
/$hx_exports
to after the function declaration. Since that leads to a bit bigger output, I only enabled this behavior when in debug mode.